[txs] better error messages on txs that need auth (#407)

Co-authored-by: Lucietta LeLegato <[email protected]>
Co-authored-by: Paoletta Saint Fortissimo <[email protected]>
Co-authored-by: Chiaretta Fortissimo <[email protected]>
Co-authored-by: Montague Von Wren <[email protected]>
Co-authored-by: Caro Polecat <[email protected]>
Co-authored-by: Peregrine De Beaver <[email protected]>
Co-authored-by: Algernon di Leveret <[email protected]>

Author: 8 people

framework/libra-framework/sources/coin.move

@@ -552,7 +552,7 @@ module diem_framework::coin {
     // NOTE 0L: Locking down transfers so that only system contracts can use this
     // to enforce transfer limits on higher order contracts.
     /// Transfers `amount` of coins `CoinType` from `from` to `to`.
-    public(friend) entry fun transfer<CoinType>(
+    public(friend) fun transfer<CoinType>(
         from: &signer,
         to: address,
         amount: u64,

framework/libra-framework/sources/ol_sources/activity.move

@@ -97,7 +97,7 @@ module ol_framework::activity {
     }
   }
 
-  fun assert_initialized(user: address) {
+  public fun assert_initialized(user: address) {
     // check malformed accounts with microsecs
     assert!(exists<Activity>(user), error::invalid_state(EACCOUNT_NOT_MIGRATED));
   }

framework/libra-framework/sources/ol_sources/community_wallet_init.move

@@ -14,6 +14,7 @@ module ol_framework::community_wallet_init {
     use ol_framework::match_index;
     use ol_framework::community_wallet;
     use ol_framework::community_wallet_advance;
+    use ol_framework::reauthorization;
 
 
     #[test_only]
@@ -71,11 +72,14 @@ module ol_framework::community_wallet_init {
       initial_authorities: vector<address>,
       check_threshold: u64,
     ) {
+      let signer_addr = signer::address_of(sig);
+      reauthorization::assert_v8_authorized(signer_addr);
+
       check_proposed_auths(initial_authorities, check_threshold);
 
       donor_voice_txs::make_donor_voice(sig);
 
-      if (!donor_voice_txs::is_liquidate_to_match_index(signer::address_of(sig))) {
+      if (!donor_voice_txs::is_liquidate_to_match_index(signer_addr)) {
         donor_voice_txs::set_liquidate_to_match_index(sig, true);
       };
       match_index::opt_into_match_index(sig);

framework/libra-framework/sources/ol_sources/donor_voice_txs.move

@@ -894,6 +894,11 @@ module ol_framework::donor_voice_txs {
     let pro_rata_addresses = vector::empty<address>();
     let pro_rata_amounts = vector::empty<u64>();
 
+    // If there are no donations yet, return empty vectors
+    if (all_time_donations == 0) {
+      return (pro_rata_addresses, pro_rata_amounts)
+    };
+
     let i = 0;
     let len = vector::length(&donors);
     while (i < len) {
@@ -1005,6 +1010,8 @@ module ol_framework::donor_voice_txs {
     description: vector<u8>,
     advance_unlocked: bool,
   )  acquires TxSchedule {
+    reauthorization::assert_v8_authorized(signer::address_of(&auth));
+
     donor_voice_reauth::assert_authorized(multisig_address);
 
     let pay_is_slow = slow_wallet::is_slow(payee);
@@ -1031,6 +1038,8 @@ module ol_framework::donor_voice_txs {
   /// by the tx_id.
   /// Public entry function required for txs cli.
   public entry fun propose_veto_tx(donor: &signer, multisig_address: address, tx_id: u64) acquires TxSchedule, Freeze{
+    reauthorization::assert_v8_authorized(signer::address_of(donor));
+
     let guid = guid::create_id(multisig_address, tx_id);
     // one thing is the id of the scheduled payment
     // another ID is that of the veto proposal
@@ -1041,24 +1050,12 @@ module ol_framework::donor_voice_txs {
     }
   }
 
-  // /// A signer of the multisig can propose a payment
-  // /// Public entry function required for txs cli
-  // public entry fun propose_advance_tx(
-  //   auth: signer,
-  //   multisig_address: address,
-  //   payee: address,
-  //   value: u64,
-  //   description: vector<u8>,
-  // ) {
-  //   donor_voice_reauth::assert_authorized(multisig_address);
-  //   propose_advance(&auth, multisig_address, payee, value, description);
-  // }
-
   // REAUTH TXs
 
   /// After proposed, subsequent donors can vote to reauth an account
   /// Public entry function required for txs cli.
   public entry fun vote_reauth_tx(donor: &signer, multisig_address: address) acquires TxSchedule {
+    reauthorization::assert_v8_authorized(signer::address_of(donor));
     donor_voice_governance::assert_is_voter(donor, multisig_address);
     let state = borrow_global<TxSchedule>(multisig_address);
     let guid_cap = &state.guid_capability;
@@ -1075,10 +1072,14 @@ module ol_framework::donor_voice_txs {
   /// A donor can propose the liquidation of a Donor Voice account
   /// Public entry function required for txs cli.
   public entry fun propose_liquidate_tx(donor: &signer, multisig_address: address)  acquires TxSchedule {
+    reauthorization::assert_v8_authorized(signer::address_of(donor));
+
     propose_liquidation(donor, multisig_address);
   }
   /// After proposed, subsequent voters call this to vote liquidation
   public entry fun vote_liquidation_tx(donor: &signer, multisig_address: address) acquires Freeze {
+    reauthorization::assert_v8_authorized(signer::address_of(donor));
+
     liquidation_handler(donor, multisig_address);
   }
 

framework/libra-framework/sources/ol_sources/ol_account.move

@@ -276,6 +276,7 @@ module ol_framework::ol_account {
   public entry fun transfer(sender: &signer, to: address, amount: u64)
   acquires BurnTracker {
     let payer = signer::address_of(sender);
+    reauthorization::assert_v8_authorized(payer);
 
     // community wallets cannot use ol_transfer, they have a dedicated workflow
     assert!(!community_wallet::is_init(payer),

framework/libra-framework/sources/ol_sources/vouch_lib/vouch_txs.move

@@ -5,19 +5,25 @@ module ol_framework::vouch_txs {
   use std::signer;
   use diem_framework::stake;
   use diem_framework::transaction_fee;
+  use ol_framework::activity;
   use ol_framework::founder;
   use ol_framework::ol_account;
   use ol_framework::page_rank_lazy;
   use ol_framework::vouch;
   use ol_framework::vouch_limits;
 
   public entry fun vouch_for(grantor: &signer, friend_account: address) {
+    // better error message
+    activity::assert_initialized(friend_account);
+
+    // You say you want a revolution
     let grantor_addr = signer::address_of(grantor);
     vouch_limits::assert_under_limit(grantor_addr, friend_account);
     page_rank_lazy::mark_as_stale(friend_account);
     vouch::vouch_for(grantor, friend_account);
     maybe_debit_validator_cost(grantor, friend_account);
     founder::maybe_set_friendly_founder(friend_account);
+    // you better free your mind instead
   }
 
   public entry fun revoke(grantor: &signer, friend_account: address) {