[donor-voice] add checks on accounts for propose payment (#395)

Co-authored-by: Rosina O'Crescendo <rosina_o'[email protected]>
Co-authored-by: Reginald Urchin <[email protected]>

Author: 3 people

framework/libra-framework/sources/ol_sources/community_wallet_advance.move

@@ -189,8 +189,11 @@ module ol_framework::community_wallet_advance {
   #[view]
   /// check if amount withdrawn will be below credit limit
   public fun can_withdraw_amount(dv_account: address, amount: u64): bool acquires Advances {
-    assert!(amount> 0, error::invalid_argument(EAMOUNT_IS_ZERO));
-    assert!(!is_delinquent(dv_account), error::invalid_state(ELOAN_OVERDUE));
+    assert!(amount > 0, error::invalid_argument(EAMOUNT_IS_ZERO));
+    // TODO: delinquent checks requires a payment history
+    // and ability to service the loan.
+    // for v8 we depend on total credit available
+    // assert!(!is_delinquent(dv_account), error::invalid_state(ELOAN_OVERDUE));
     let available = total_credit_available(dv_account);
     available > amount
   }

framework/libra-framework/sources/ol_sources/donor_voice_txs.move

@@ -229,17 +229,22 @@ module ol_framework::donor_voice_txs {
     /// and the limits must not have been exceeded.
 
     /// Returns the GUID of the transfer.
-    public(friend) fun propose_payment(
+    fun propose_payment(
       sender: &signer,
       multisig_address: address,
       payee: address,
       value: u64,
       description: vector<u8>,
     ): guid::ID acquires TxSchedule {
+      // check the CW has been reauthorized
+      donor_voice_reauth::assert_authorized(multisig_address);
+      // check the multisig admin is initialized
+      reauthorization::assert_v8_authorized(signer::address_of(sender));
+      // check the payee is initialized
+      reauthorization::assert_v8_authorized(payee);
 
-      assert!(!ol_features_constants::is_governance_mode_enabled(), error::invalid_state(EGOVERNANCE_MODE));
 
-      donor_voice_reauth::assert_authorized(multisig_address);
+      assert!(!ol_features_constants::is_governance_mode_enabled(), error::invalid_state(EGOVERNANCE_MODE));
 
 
       // Commit note: don't abort on not slow wallet, in cases of unlocked advance

framework/libra-framework/sources/ol_sources/tests/donor_voice.test.move

@@ -463,7 +463,7 @@ module ol_framework::test_donor_voice {
 
       donor_voice_reauth::test_set_authorized(root, donor_voice_address);
 
-      let uid = donor_voice_txs::propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), 100, b"thanks marlon");
+      let uid = donor_voice_txs::test_propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), 100, b"thanks marlon");
       let (found, idx, status_enum, completed) = donor_voice_txs::get_multisig_proposal_state(donor_voice_address, &uid);
       assert!(found, 7357004);
       assert!(idx == 0, 7357005);
@@ -596,7 +596,7 @@ module ol_framework::test_donor_voice {
 
       slow_wallet::user_set_slow(marlon_rando);
 
-      let first_uid_bob = donor_voice_txs::propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), marlon_pay_one, b"thanks marlon");
+      let first_uid_bob = donor_voice_txs::test_propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), marlon_pay_one, b"thanks marlon");
       let (found, idx, status_enum, completed) = donor_voice_txs::get_multisig_proposal_state(donor_voice_address, &first_uid_bob);
       assert!(found, 7357004);
       assert!(idx == 0, 7357005);
@@ -620,7 +620,7 @@ module ol_framework::test_donor_voice {
       let list = donor_voice_txs::find_by_deadline(donor_voice_address, 3);
       assert!(vector::contains(&list, &first_uid_bob), 73570014);
 
-      let second_uid_bob = donor_voice_txs::propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), marlon_pay_two, b"thanks again!!!");
+      let second_uid_bob = donor_voice_txs::test_propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), marlon_pay_two, b"thanks again!!!");
       let (found, idx, status_enum, completed) = donor_voice_txs::get_multisig_proposal_state(donor_voice_address, &second_uid_bob);
       assert!(found, 73570015);
       assert!(idx == 0, 73570016); // since the above payment was approved, now
@@ -727,7 +727,7 @@ module ol_framework::test_donor_voice {
 
       slow_wallet::user_set_slow(marlon_rando);
 
-      let uid = donor_voice_txs::propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), marlon_pay_one, b"thanks marlon");
+      let uid = donor_voice_txs::test_propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), marlon_pay_one, b"thanks marlon");
       let (found, idx, status_enum, completed) = donor_voice_txs::get_multisig_proposal_state(donor_voice_address, &uid);
       assert!(found, 7357004);
       assert!(idx == 0, 7357005);
@@ -755,7 +755,7 @@ module ol_framework::test_donor_voice {
       // one epoch goes by and then new payment to marlon
       mock::trigger_epoch(root); // into epoch 1
 
-      let second_uid_bob = donor_voice_txs::propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), marlon_pay_two, b"thanks again!!!");
+      let second_uid_bob = donor_voice_txs::test_propose_payment(bob, donor_voice_address, signer::address_of(marlon_rando), marlon_pay_two, b"thanks again!!!");
       let (found, idx, status_enum, completed) = donor_voice_txs::get_multisig_proposal_state(donor_voice_address, &second_uid_bob);
       assert!(found, 73570015);
       assert!(idx == 0, 73570016); // now pending is empty, should be first