Rebranding

Author: 0blu

.github/ISSUE_TEMPLATE/bug_report.md

@@ -8,5 +8,5 @@ assignees: ''
 ---
 
 Wait a moment,
-are you sure you want to create an issue with this launcher?
-You probably want to create an issue at HermesProxy: https://github.com/WowLegacyCore/HermesProxy
+are you sure you want to create an issue with **this** launcher?
+If you have gameplay issues start a new BugReport at HermesProxy: https://github.com/WowLegacyCore/HermesProxy

.github/workflows/Build_Launcher.yml

@@ -1,4 +1,4 @@
-name: Build Proxy
+name: Build Launcher
 
 on: ['push']
 
@@ -30,11 +30,11 @@ jobs:
         run: dotnet publish --configuration Release --use-current-runtime -p:UsePublishBuildSettings=true
 
       - name: Copy files
-        run: cp -r ./EverlookClassic.Launcher/bin/Release/*/publish/ publish
+        run: cp -r ./WinterspringLauncher/bin/Release/*/publish/ publish
 
       - name: Upload build artifact
         uses: actions/upload-artifact@v3
         with:
-          name: EverlookClassic-${{ matrix.os }}-${{ runner.arch }}-${{ github.sha }}
+          name: WinterspringLauncher-${{ matrix.os }}-${{ runner.arch }}-${{ github.sha }}
           path: publish
           if-no-files-found: error

EverlookClassic.sln.DotSettings

@@ -1,4 +1,5 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Arctium/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Everlook/@EntryIndexedValue">True</s:Boolean>
-	<s:Boolean x:Key="/Default/UserDictionary/Words/=realmlist/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=realmlist/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Winterspring/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>

README.md

@@ -2,8 +2,11 @@
     <img align="right" src="./everlook-classic-icon.png" alt="icon">
 </figure>
 
-# Everlook Classic Launcher
-Allows you to play on [Everlook.org](https://everlook.org/) with modern 1.14 WoW Client!
+# Winterspring Launcher
+Allows you to play on [Everlook.org](https://everlook.org/) with modern 1.14 WoW Client!  
+_This is not an official project from the Everlook team._  
+_Do not ask the Everlook team for support_  
+_(you can still ask in [#addons-and-ui](https://discord.com/channels/973529971740008448/983067524797177996) on Discord)_ 
 
 ## Easy setup
 The launcher will do everything for you.  
@@ -15,31 +18,33 @@ When HermesProxy has an update it is automatically applied.
 3. Run it
 4. **Enjoy your stay on Everlook**
 
-## Why
+## Why?
 The modern WoW-Classic client provides many improvements in hardware compatibility and accessibility.
 
 With Everlook we have the unique chance to improve HermesProxy with a large testing audience.   
 The launcher will make the classic client accessible to everyone.  
-So if you find any bugs [please report them](https://github.com/WowLegacyCore/HermesProxy/issues/new/choose).
+So if you find any bugs [please report them](https://github.com/WowLegacyCore/HermesProxy/issues/new/choose).  
+(If you find any bugs associated to the launcher report them [here](https://github.com/0blu/WinterspringLauncher/issues))
 
 ## Is this allowed?
 Currently HermesProxy is tolerated on Everlook.  
-You will get suspended if you exploit any game breaking bugs.  
+⚠️You **will** get suspended if you exploit any game breaking bugs.  
+So far no-one has been banned for using official HermesProxy.  
 Just use common sense and <u>**play fair**</u>!
 
 ## Addons
 Most addons for 1.14.x should work.  
 You can download older versions from CurseForge under the "Files" tab. ([Example](https://www.curseforge.com/wow/addons/questie/files/all?filter-game-version=2020709689%3A9094))  
-Here are some working recommendations:
-
+Here are some working recommendations:  
+(click the [[dl](#)] link to get a working zip)
 ### Questing
-- [Questie](https://www.curseforge.com/wow/addons/questie/download/3519759)
-- [Guidelime (base)](https://www.curseforge.com/wow/addons/guidelime/download/4026001)
-- [Guidelime: Sage Guide](https://www.curseforge.com/wow/addons/guidelime_sage/download/3810259) (Alliance)
-- [Guidelime: Busteas Guide](https://www.curseforge.com/wow/addons/guidelime-busteas-1-60-leveling/download/3521451) (Horde)
+- [[dl](https://www.curseforge.com/wow/addons/questie/download/3519759)] [Questie](https://www.curseforge.com/wow/addons/questie) <- Must have. Even in combination with other addons.
+- [[dl](https://www.curseforge.com/wow/addons/guidelime/download/4026001)] [Guidelime (base)](https://www.curseforge.com/wow/addons/guidelime)
+- [[dl](https://www.curseforge.com/wow/addons/guidelime_sage/download/3810259)] [Guidelime: Sage Guide](https://www.curseforge.com/wow/addons/guidelime_sage) (Alliance)
+- [[dl](https://www.curseforge.com/wow/addons/guidelime-busteas-1-60-leveling/download/3521451)] [Guidelime: Busteas Guide](https://www.curseforge.com/wow/addons/guidelime-busteas-1-60-leveling) (Horde)
 
 ### Interface
-- [ModernTargetFrame](https://www.curseforge.com/wow/addons/modern-targetframe/download/4024275) (To see the HP of mobs)
+- [[dl](https://www.curseforge.com/wow/addons/modern-targetframe/download/4024275)] [ModernTargetFrame](https://www.curseforge.com/wow/addons/modern-targetframe) (To see the HP of mobs)
 
 (Feel free to give me new recommendations to extend the list)
 

EverlookClassic.sln WinterspringLauncher.slnEverlookClassic.sln renamed to WinterspringLauncher.sln

@@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Version 17
 VisualStudioVersion = 17.0.31903.59
 MinimumVisualStudioVersion = 10.0.40219.1
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EverlookClassic.Launcher", "EverlookClassic.Launcher\EverlookClassic.Launcher.csproj", "{605A76A1-9D23-4C31-8699-FC89E4B5394A}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WinterspringLauncher", "WinterspringLauncher\WinterspringLauncher.csproj", "{605A76A1-9D23-4C31-8699-FC89E4B5394A}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution

WinterspringLauncher.sln.DotSettings

@@ -0,0 +1,5 @@
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Arctium/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Everlook/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=realmlist/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Winterspring/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>

EverlookClassic.Launcher/7z.dll WinterspringLauncher/7z.dllEverlookClassic.Launcher/7z.dll renamed to WinterspringLauncher/7z.dll

@@ -5,10 +5,10 @@
 using System.Security.Cryptography;
 using System.Text;
 using System.Xml;
-using EverlookClassic.Launcher.Utils;
 using SevenZip;
+using WinterspringLauncher.Utils;
 
-namespace EverlookClassic.Launcher;
+namespace WinterspringLauncher;
 
 public static class LauncherActions
 {
@@ -17,7 +17,7 @@ public static class LauncherActions
     public static void UpdateThisLauncher(GitHubReleaseInfo releaseInfo)
     {
         Console.WriteLine("A new version was released, please update");
-        Console.WriteLine("https://github.com/0blu/EverlookClassicLauncher/releases");
+        Console.WriteLine("https://github.com/0blu/WinterspringLauncher/releases");
         Thread.Sleep(TimeSpan.FromSeconds(12));
     }
 
@@ -39,26 +39,6 @@ bool IsCorrectChecksum(string subPath, string expectedHash)
             return IsCorrectChecksum("_classic_era_/WowClassic.exe", "5e200eafe8bd2ec4baab38f3f66849c9");
     }
 
-    private static void DownloadArctiumIfNecessary(string arctiumPath)
-    {
-        bool IsValidArctiumInstallation(string arctiumPath)
-        {
-            return false;
-        }
-        
-        if (IsValidArctiumInstallation(arctiumPath))
-        {
-            Console.WriteLine($"Arctium found in: {arctiumPath}");
-        }
-        else
-        {
-            Console.WriteLine("Arctium-WoW-Launcher not found!");
-            Console.WriteLine($"Downloading it into {arctiumPath}");
-            Thread.Sleep(TimeSpan.FromSeconds(6));
-            Console.WriteLine(" > Complete");
-        }
-    }
-
     public static void CreateDesktopShortcut()
     {
         try
@@ -72,7 +52,7 @@ public static void CreateDesktopShortcut()
             {
                 Console.WriteLine("Replacing existing Desktop Icon");
             }
-            
+
             string? target = Process.GetCurrentProcess().MainModule?.FileName;
             if (target == null)
             {
@@ -250,7 +230,7 @@ public static void ExtractGameClient(string gamePath, bool onlyData)
         }
 
         var assembly = Assembly.GetExecutingAssembly();
-        var resourceName = "EverlookClassic.Launcher.7z.dll";
+        var resourceName = "WinterspringLauncher.7z.dll";
 
         using (Stream stream = assembly.GetManifestResourceStream(resourceName)!)
         {
@@ -364,8 +344,9 @@ public static void PrepareHermesProxyConfig(string hermesPath, string realmlist)
         XmlDocument doc = new XmlDocument();
         doc.Load(hermesConfigPath);
 
+        const string modifiedAttrName = "WinterspringLauncherModified";
         var configNode = doc.DocumentElement!.SelectSingleNode("/configuration")!;
-        XmlNode? alreadyModifiedByUsMarker = configNode.SelectSingleNode("EverlookClassicModified");
+        XmlNode? alreadyModifiedByUsMarker = configNode.SelectSingleNode(modifiedAttrName);
         if (alreadyModifiedByUsMarker == null)
         {
             XmlNode appSettings = configNode.SelectSingleNode("appSettings")!;
@@ -376,7 +357,7 @@ public static void PrepareHermesProxyConfig(string hermesPath, string realmlist)
             XmlNode packetLogNode = appSettings.SelectSingleNode("add[@key='PacketsLog']")!;
             packetLogNode.Attributes!["value"]!.Value = "false";
 
-            var modifiedMarker = doc.CreateElement("EverlookClassicModified");
+            var modifiedMarker = doc.CreateElement(modifiedAttrName);
             modifiedMarker.SetAttribute("comment", "This file might get overwritten when new Hermes update is applied");
             configNode.InsertBefore(modifiedMarker, configNode.FirstChild);
 

…rlookClassic.Launcher/LauncherActions.cs WinterspringLauncher/LauncherActions.csEverlookClassic.Launcher/LauncherActions.cs renamed to WinterspringLauncher/LauncherActions.cs EverlookClassic.Launcher/LauncherActions.cs renamed to WinterspringLauncher/LauncherActions.cs

@@ -1,15 +1,19 @@
 using System.Text;
 using System.Text.Json;
+using System.Text.Json.Serialization;
 
-namespace EverlookClassic.Launcher;
+namespace WinterspringLauncher;
 
 public class LauncherConfig
 {
     public const string DEFAULT_DOWNLOAD_URL = "default";
 
     public int ConfigVersion { get; set; } = 1;
 
-    public string GitRepoEverlookClassic { get; set; } = "0blu/EverlookClassicLauncher";
+    [Obsolete("Replaced with 'GitRepoWinterspringLauncher'")]
+    [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+    public string? GitRepoEverlookClassic  { get; set; }
+    public string GitRepoWinterspringLauncher { get; set; } = "0blu/WinterspringLauncher";
     public string GitRepoHermesProxy { get; set; } = "WowLegacyCore/HermesProxy";
     public string GitRepoArctiumLauncher { get; set; } = "Arctium/WoW-Launcher";
 
@@ -31,7 +35,7 @@ public void SaveConfig(string configPath)
         string jsonString = JsonSerializer.Serialize(this, options);
         File.WriteAllText(configPath, jsonString, Encoding.UTF8);
     }
-    
+
     public static LauncherConfig LoadOrCreateDefault(string configPath)
     {
         LauncherConfig config;
@@ -62,6 +66,11 @@ public static LauncherConfig LoadOrCreateDefault(string configPath)
 
     private static void PatchConfigIfNeeded(LauncherConfig config)
     {
+#pragma warning disable CS0618
+        if (config.GitRepoEverlookClassic != null)
+            config.GitRepoEverlookClassic = null; // remove old repo from config
+#pragma warning restore CS0618
+
         if (config.ConfigVersion < 2)
         {
             // For future use

…erlookClassic.Launcher/LauncherConfig.cs WinterspringLauncher/LauncherConfig.csEverlookClassic.Launcher/LauncherConfig.cs renamed to WinterspringLauncher/LauncherConfig.cs EverlookClassic.Launcher/LauncherConfig.cs renamed to WinterspringLauncher/LauncherConfig.cs

@@ -1,13 +1,14 @@
 using System.Globalization;
 using System.Reflection;
 using System.Runtime.InteropServices;
-using EverlookClassic.Launcher.Utils;
+using WinterspringLauncher.Utils;
 
-namespace EverlookClassic.Launcher;
+namespace WinterspringLauncher;
 
 class Launcher
 {
-    private const string CONFIG_FILE_NAME = "everlook-classic.json";
+    private const string LEGACY_CONFIG_FILE_NAME = "everlook-classic.json";
+    private const string CONFIG_FILE_NAME = "winterspring-launcher-config.json";
 
     internal static void Main()
     {
@@ -21,6 +22,17 @@ internal static void Main()
         string FullPath(string subPath) => Path.GetFullPath(Path.Combine(baseFolder, subPath));
 
         string configPath = Path.Combine(baseFolder, CONFIG_FILE_NAME);
+        // Convert legacy config into new one
+        IgnoreExceptions("rename old config", () => {
+            string legacyConfigPath = Path.Combine(baseFolder, LEGACY_CONFIG_FILE_NAME);
+            if (File.Exists(legacyConfigPath))
+            {
+                Console.WriteLine($"Renaming old config to {CONFIG_FILE_NAME}");
+                Thread.Sleep(1);
+                File.Move(legacyConfigPath, configPath);
+            }
+        });
+
         var config = LoadConfig(configPath);
         var api = new UpdateApiClient(config);
 
@@ -58,16 +70,19 @@ internal static void Main()
 
     private static void UpdateThisLauncherIfNecessary(UpdateApiClient api)
     {
-        var v = Assembly.GetExecutingAssembly().GetName().Version!;
-        string myLauncherVersion = $"{v.Major}.{v.Minor}.{v.Build}";
+        Version myVersion = Assembly.GetExecutingAssembly().GetName().Version!;
+        string myVersionStr = $"{myVersion.Major}.{myVersion.Minor}.{myVersion.Build}";
 
         GitHubReleaseInfo latestLauncherVersion = api.GetLatestThisLauncherRelease();
-
-        if (latestLauncherVersion.TagName != null && myLauncherVersion != latestLauncherVersion.TagName)
+        if (latestLauncherVersion.TagName != null && myVersionStr != latestLauncherVersion.TagName)
         {
-            Console.WriteLine($"New launcher update {myLauncherVersion} => {latestLauncherVersion.TagName}");
-            // This function might not return because it updates the launcher in-place
-            LauncherActions.UpdateThisLauncher(latestLauncherVersion);
+            var newVersion = Version.Parse(latestLauncherVersion.TagName);
+            if (newVersion > myVersion)
+            {
+                Console.WriteLine($"New launcher update {myVersionStr} => {latestLauncherVersion.TagName}");
+                // This function might not return because it updates the launcher in-place
+                LauncherActions.UpdateThisLauncher(latestLauncherVersion);
+            }
         }
     }
 
@@ -222,6 +237,7 @@ private static string GetVersionInformation()
     private static void PrintLogo()
     {
         Console.WriteLine($"Version: {GetVersionInformation()}");
+        Console.WriteLine("https://github.com/0blu/WinterspringLauncher");
         Console.WriteLine("");
 
         void WriteWithASubtext(string logo, string subText)
@@ -237,7 +253,7 @@ void WriteWithASubtext(string logo, string subText)
         Console.WriteLine("            ...      ..");
         Console.WriteLine("       .,,,,,..        .,,");
         Console.WriteLine("     ,,,,,    ....       ,,,");
-        WriteWithASubtext("    .,,,.  ,,,,,,,,,,,    ,,,", "      Everlook Classic");
+        WriteWithASubtext("    .,,,.  ,,,,,,,,,,,    ,,,", "        Winterspring");
         WriteWithASubtext("    ,,,,. .,,,,   ,,,,.   ,,,,", "         Launcher");
         Console.WriteLine("    .,,,,         ,,,,.   ,,,,");
         WriteWithASubtext("     ,,,,,,,...,,,,,,,   ,,,,.", "      Allows you to");