[fix]: VerifyCmd Flag Collision #1513
Conversation
miden/src/cli/verify.rs
Outdated
| #[clap(short = 'x', long = "hash")] | ||
| program_hash: String, |
There was a problem hiding this comment.
I would probably keep the long name as program-hash as it is more self-describing.
miden/src/cli/verify.rs
Outdated
| #[clap(short = 'p', long = "proof", value_parser)] | ||
| proof_file: PathBuf, | ||
| proof_file: Option<PathBuf>, |
There was a problem hiding this comment.
I would keep proof_file as required and try to infer input/output files based on it (rather than using input file to infer proof/output file).
miden/src/cli/verify.rs
Outdated
| pub fn execute(&mut self) -> Result<(), Report> { | ||
|
|
||
| let (proof_file,output_file)=self.infer_defaults(); | ||
|
|
||
| self.proof_file=Some(proof_file); | ||
| self.output_file=Some(output_file); |
There was a problem hiding this comment.
I'm not sure we need to make self mutable here. Once we get the inferred files we can probably use them directly rather than reading them from self.
miden/src/cli/verify.rs
Outdated
| @@ -62,4 +69,26 @@ impl VerifyCmd { | |||
|
|
|||
| Ok(()) | |||
| } | |||
| } | |||
|
|
|||
| pub fn infer_defaults(&self)->(PathBuf,PathBuf){ | |||
There was a problem hiding this comment.
As mentioned in another comment, I'd probably infer input/output files based on the proof file rather than the other way around.
Also, I don't think this function needs to be public, right?
|
Hi @varun-doshi - any interest in pushing this PR over the finish line? |
Hi yes apologies for the delay |
Describe your changes
Related #1421
This PR does the following:
program-hashto-x. No long forminfer_defaultsfunction which checks the directory specified by the input file passed(with-i) to search for a.proofand.outputsfile (only if these files are not already specified) . If these files are already specified by user, then it does not run this check.Hence the command can be called as such:
as well as such:
TODO:
Checklist before requesting a review
nextaccording to naming convention.