Skip to content

Reduce event information #10

Open
Open
@duncancmt

Description

@duncancmt

// TODO actually calculate the orderHash
emit OtcOrderFilled(
witness, order.maker, taker, order.makerToken, order.takerToken, order.makerAmount, order.takerAmount
);

In keeping with our philosophy of reducing the gas consumed by emitting events, can this event be pruned down to contain just the witness? The witness uniquely identifies the order itself, and the actual fill amounts can be inferred from the Transfer events fired by the 2 tokens.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions