-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to jekyll 4.x #46
Comments
Noting old gem version incompatibilities here for reference:
This was done after updating a couple of things already:
This is a dependency of
|
My guess is this deprecated usage will be part of
Support for redcarpet and other markdown processors was dropped. Need to update our usages to kramdown.
Our Jekyll config will likely require changes too:
Kramdown seems to have a number of other issues too, eg:
Not specifically Kramdown related.. but:
With my dotfiles layout, I believe we could also add this to I think using a gitignored |
It seems as though this may be the original source for this plugin: It hasn't been updated since 2017, and requires manually copying the plugin source into our project. We might be better off just removing it and manually using a twitter filter around links instead? |
Kramdown seems to have weird quirks that don't really match to GitHub Flavoured Markdown (GFM) as I would have expected it. An alternative would be to use commonmark (which also appears to be what GitHub pages uses), but there seem to be 2 main versions that appear to use the same underlying
The Though as I note in github/jekyll-commonmark-ghpages#18:
commonmarker configuration:
I explore some relevant sounding choices in github/pages-gem#699 (comment), summarised as:
When I don't have The main page that I noticed this on was
Setting the Searching for
Based on this, it seems like we may have to use It also appears that the
Again, given I control the source/inputs to this, there probably isn't a lot of real world risk in removing the According to github/pages-gem#651, the best recommended way to support Jekyll 4 on GitHub pages currently is to use GitHub actions:
|
Fixed up most of the broken gist embeds, but one page still appears to be having issues, seems it may be a bug in |
We have previously used an inlined plugin called This is used with syntax such as the following:
And appears to be used in the following posts:
Both of the There appears to be a maintained (last commit 2020, last release 2019), gem based jekyll plugin that also provides this functionality, though it differs slightly in it's usage: Instead of using a Instead of having to explicitly use a liquid filter (eg. It's probably a better choice to use going forward.
|
Currently we're on v3.8.0 (ref):
Changelog:
Upgrading:
See also:
The text was updated successfully, but these errors were encountered: