Always truthy error

mscuthbert · web-flow · commit 046941e40665 · 2025-02-06T14:03:29.000-10:00
Remove part of a line in tables.ts that will never be executed -- raises a compiler error in Typescript 5.6 and above.  Probably a result of a refactor.  Will commit also to VF5 repo.
diff --git a/src/tables.ts b/src/tables.ts
@@ -635,7 +635,7 @@ export class Tables {
     let customNoteHeadProps = {};
     if (pieces.length > 2 && pieces[2]) {
       const glyphName = pieces[2].toUpperCase();
-      customNoteHeadProps = { code: this.codeNoteHead(glyphName, duration) } || {};
+      customNoteHeadProps = { code: this.codeNoteHead(glyphName, duration) };
     }
 
     return {

Original file line number	Diff line number	Diff line change
`@@ -635,7 +635,7 @@ export class Tables {`
`635`	`635`	`let customNoteHeadProps = {};`
`636`	`636`	`if (pieces.length > 2 && pieces[2]) {`
`637`	`637`	`const glyphName = pieces[2].toUpperCase();`
`638`		`- customNoteHeadProps = { code: this.codeNoteHead(glyphName, duration) } \|\| {};`
	`638`	`+ customNoteHeadProps = { code: this.codeNoteHead(glyphName, duration) };`
`639`	`639`	`}`
`640`	`640`
`641`	`641`	`return {`