Confusion in the links on the Contributing Guidelines

[glebkema]

I noticed 4 links to the contributing guidelines. But they are all different and 2 of them do not work.

• The blocks on the Issues page and on the New Issue page open https://github.com/10up/.github/blob/master/CONTRIBUTING.md
  This link works. But the text recommends open up PRs against the develop branch, which is not in this repository. And 3 of 4 links in the text open the 404 error page.

• The block on the Contribute page has link on https://github.com/10up/Engineering-Best-Practices/blob/gh-pages/CONTRIBUTING.md
  Error 404.

• Checklist in PR template sends to read https://github.com/CONTRIBUTING.md
  There is no such page either, however the visitor will see not error 440, but an invitation to work in GitHub ;) https://github.com/about/careers

I think it’s important to put things in order because all beginners should read this document and because in each PR we put a cross I have read the CONTRIBUTING document.

[jeffpaul]

@glebkema thanks for the feedback, what you're seeing is definitely odd and something that should get cleaned up.

The links on the Issues page are utilizing the 10up default Contributing Guidelines markdown file, so that'll likely be resolved by creating a replica of https://github.com/10up/.github/blob/master/CONTRIBUTING.md and customizing it as necessary for the Engineering Best Practices.

The Contribute page, honestly, was not a page I was aware of and looks to be a hidden page in the GitHub UI. Resolving for the Issues page above will likely (hopefully?) resolve this dead link.

The PR template is also using the 10up default PR template file, so that'll likely be resolved by creating a replica of https://github.com/10up/.github/blob/master/.github/PULL_REQUEST_TEMPLATE.md and customizing it as necessary for the Engineering Best Practices. I'll make a note that removing the link in the .github repo version of this file is likely warranted to avoid this same scenario for other repos inheriting this file.

Finally, we may want to link to the newly created CONTRIBUTING.md file from the https://10up.github.io/Engineering-Best-Practices/#contributing section to provide more details than what's currently stated.

@timwright12 if you're 👍 on these changes, then I'll work on a PR for you to review.

[tlovett1]

Those changes sound good to me @jeffpaul