Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions regarding the build process #105

Open
mtoensing opened this issue Aug 11, 2022 · 0 comments
Open

questions regarding the build process #105

mtoensing opened this issue Aug 11, 2022 · 0 comments

Comments

@mtoensing
Copy link

Hi! Thank you very much for this GitHub action! This streamlined my process to deploy my SimpleTOC Plug-In: https://github.com/mtoensing/simpletoc/blob/master/.github/workflows/deploy.yml

I use the "build" feature and have a few questions. When I use

Run npm install @wordpress/scripts --save-dev

I get these warnings and the process pauses for a few seconds. Is this normal and intended? Can I remove the warnings somehow?

Run npm install @wordpress/scripts --save-dev
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react
npm WARN   peer react@">=16.8.0" from @emotion/[email protected]
npm WARN   node_modules/@emotion/react
npm WARN     peer @emotion/react@"^11.0.0-rc.0" from @emotion/[email protected]
npm WARN     node_modules/@emotion/styled
npm WARN     1 more (@wordpress/components)
npm WARN   30 more (@emotion/styled, @floating-ui/react-dom, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^0.14 || ^[15](https://github.com/mtoensing/simpletoc/runs/7794469494?check_suite_focus=true#step:3:16).5.4 || ^16.1.1" from [email protected]
npm WARN node_modules/react-dates
npm WARN   react-dates@"^21.8.0" from @wordpress/[email protected]
npm WARN   node_modules/@wordpress/components
npm WARN 
npm WARN Conflicting peer dependency: react@[16](https://github.com/mtoensing/simpletoc/runs/7794469494?check_suite_focus=true#step:3:17).14.0 ....

My other question is: Is the build process just for validation, or is it used for the commit to svn? So if I use "npm start" locally will the resulting JavaScript be used or the compiled script from your action?

Thank you! =)

@mtoensing mtoensing changed the title Questions regarding the build process questions regarding the build process Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant