Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-output command deprecated in last release #118

Open
julienloizelet opened this issue Mar 23, 2023 · 4 comments
Open

set-output command deprecated in last release #118

julienloizelet opened this issue Mar 23, 2023 · 4 comments
Labels
help wanted Extra attention is needed type:bug Something isn't working.
Milestone

Comments

@julienloizelet
Copy link

Describe the bug

Hi, and thanks for this useful action :)

When running the last 2.1.1 release, there is a warning :

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Reading the content of the link to follow, we have :

Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error.

I saw that it has been fixed in this commit : c85e3f4

Is it possible to have a new release that include this commit (or to schedule one before June)?

Steps to Reproduce

  1. Run the 2.1.1 version

Expected behavior
No warning

Additional context

@jeffpaul jeffpaul added this to the 2.2.0 milestone Mar 23, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Mar 23, 2023
@jeffpaul jeffpaul added type:bug Something isn't working. help wanted Extra attention is needed labels Mar 23, 2023
@jeffpaul
Copy link
Member

@julienloizelet thanks for the detailed report, I'll see if we've got someone that can work on a fix for this but would otherwise be open to anyone else able to contribute a PR as well

@julienloizelet
Copy link
Author

Hi @jeffpaul, fix is already done with this commit c85e3f4

It would be enough to publish a release integrating this commit.

Thanks

@adriaandotcom
Copy link

@jeffpaul could you merge that commit when you have time? End of this month, the plugin will no longer work because of the deprecation of the set-output function.

@jeffpaul jeffpaul modified the milestones: 2.2.0, 2.3.0 May 22, 2023
@bmarshall511
Copy link

@jeffpaul Think this one can be closed, I see the c85e3f4 change in both the develop and stable branches.

@jeffpaul jeffpaul modified the milestones: 2.3.0, 2.2.0 Jun 29, 2023
@jeffpaul jeffpaul moved this from To Do to Done/Released in Open Source Practice Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:bug Something isn't working.
Projects
Archived in project
Development

No branches or pull requests

4 participants