Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu-latest lo longer comes with SVN installed #151

Open
tobeyadr opened this issue Sep 30, 2024 · 2 comments · May be fixed by #155
Open

ubuntu-latest lo longer comes with SVN installed #151

tobeyadr opened this issue Sep 30, 2024 · 2 comments · May be fixed by #155
Assignees
Labels
needs:documentation This requires documentation. type:bug Something isn't working.
Milestone

Comments

@tobeyadr
Copy link

Describe the bug
ubuntu-latest no longer has SVN installed, meaning example files will not function as expected.

Steps to Reproduce
Use ubuntu-latest in your .yml and you'll see "svn: command not found"

Expected behavior
The plugin should be deployed to SVN.

Additional context
Please recommend that authors use "ubuntu-22.04" instead in your example files.

@vikrampm1 vikrampm1 added type:bug Something isn't working. needs:documentation This requires documentation. labels Sep 30, 2024
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Sep 30, 2024
@helen
Copy link
Collaborator

helen commented Oct 1, 2024

For future-proofing it's probably not best to stay on an old OS, a more correct route would be to install subversion as a step which is actually what used to happen before this became a composite action running directly on the runner instead for speed, see 8926c88 (you'll need to load the contents of the deleted Dockerfile)

@fumikito
Copy link

F.Y.I

Same for me, and adding this step works fine :)

      - name: Install Subversion
        run: sudo apt-get install subversion

      - name: Deploy to WordPress Directory
        id: deploy
        uses: 10up/action-wordpress-plugin-deploy@stable
        with:
          generate-zip: true
        env:
          SVN_USERNAME: ${{ secrets.WP_ORG_USERNAME }}
          SVN_PASSWORD: ${{ secrets.WP_ORG_PASSWORD }}

@thrijith thrijith linked a pull request Oct 24, 2024 that will close this issue
4 tasks
@thrijith thrijith self-assigned this Oct 24, 2024
@jeffpaul jeffpaul added this to the 2.3.0 milestone Oct 24, 2024
@jeffpaul jeffpaul moved this from To Do to Code Review in Open Source Practice Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation. type:bug Something isn't working.
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

6 participants