Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push to svn on release only (not pre-release) #50

Closed
KevinBatdorf opened this issue Aug 27, 2020 · 4 comments
Closed

Push to svn on release only (not pre-release) #50

KevinBatdorf opened this issue Aug 27, 2020 · 4 comments
Labels
type:enhancement New feature or request.

Comments

@KevinBatdorf
Copy link

Similar to #5, I would like a workflow where I could tag a pre-release, run the build (including zip file), but not deploy to the svn.

The intent is to have a final round of testing with the build artifact before an actual release.

It looks like this would involve rewriting the .distignore workflow to run more like the .gitattributes, and generate the zip file from $TMP_DIR instead of the svn directly.

Does this seems like something useful? I'm not even sure it's doable, to be fair, as I'm just using Github actions now for the first time!

@KevinBatdorf KevinBatdorf added the type:enhancement New feature or request. label Aug 27, 2020
@helen
Copy link
Collaborator

helen commented Aug 17, 2021

Hi there - is this still an issue for you? It sounds like you want to run a workflow without this action at all, in which case there isn't anything to do here in this repository. Things like the build and ZIP generation can all be done directly as commands on the runner in a workflow, this action just happens to handle the ZIP part as a part of the process because of the SVN component, but if you're not dealing with that then you don't need this action at all.

@helen helen closed this as completed Aug 17, 2021
@KevinBatdorf
Copy link
Author

I wanted it to ideally not trigger on pre-release (which is a checkbox that shows when making a release). All good though, this issue was opened over a year ago so I just stopped using the pre-release feature

@helen
Copy link
Collaborator

helen commented Sep 10, 2021

I see, to get it to not run you'd want to change the trigger in your workflow file, I think it's instead of published you use released, and then a separate one for the prereleased event that runs build and creates a ZIP as the workflow steps. I hope that makes sense - you're looking for things that are managed by the GitHub part, not this particular action.

@KevinBatdorf
Copy link
Author

Thanks for following up. Just looked it up in the docs and it looks like there are "activity types" that you would target on the release event. That makes sense.

https://docs.github.com/en/actions/reference/events-that-trigger-workflows#release

Possibly going to be adding this workflow to a few projects in the coming weeks so I'll test it out and see if there are any issues. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants