-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new YAML syntax for workflow instructions #15
Comments
Thanks for opening this issue @sc0ttkclark - I'm working on making sure we use the actual |
:dance-attack: thanks! |
I've just used your GitHub action yesterday and had to migrate the HCL files to the YAML syntax. I used the migration tool from GitHub. You can find the YAML files here: https://github.com/2ndkauboy/SyntaxHighlighter-Evolved-SASS-Brush/tree/master/.github/workflows |
@sc0ttkclark @2ndkauboy If y'all have a moment, would appreciate any thoughts on the correctness and readability of #20 :) |
Looks good to me! |
I just checked your new YAML files with my plugin by updating only the readme and it looks really good. Only the readme/assets action fired and was successful! 🙌 |
@2ndkauboy @sc0ttkclark You will probably want to update the plugin deploy workflow to use the new/improved tag filtering syntax, I've updated the documentation here: https://github.com/10up/action-wordpress-plugin-deploy |
Just ran this successfully. In my case, I didn't have any npm build process that needed to run so it would fail to deploy because of npm errors. Once I removed that section it ran perfectly. |
I should note that this was probably the fastest deploy I've ever done! Not talking about steps (we had automation before) but in terms of SVN this whole process ran for 1m 38s, which only 30s was SVN. That's awesome, thank you very much for helping speed up my workflow! :) |
@sc0ttkclark Yay!!! We are actually discussing documentation of multiple examples over in 10up/action-wordpress-plugin-deploy#5 - I am worried about exactly what you experienced, which is that as people are getting these things set up for the first time, they won't quite understand that they may need to remove stuff from the sample workflow file, so maybe it should be a barebones example and link off to more examples in a separate document. |
Yeah I like that idea, knowing the easy syntax to include npm processes is super handy to know how to put the two together |
The new YAML syntax is taking over and the actions here should get migrated from HCL to YAML syntax when possible.
https://help.github.com/en/articles/migrating-github-actions-from-hcl-syntax-to-yaml-syntax
The text was updated successfully, but these errors were encountered: