Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new YAML syntax for workflow instructions #15

Closed
sc0ttkclark opened this issue Aug 20, 2019 · 11 comments · Fixed by #20
Closed

Migrate to new YAML syntax for workflow instructions #15

sc0ttkclark opened this issue Aug 20, 2019 · 11 comments · Fixed by #20
Assignees
Labels
type:enhancement New feature or request.

Comments

@sc0ttkclark
Copy link

The new YAML syntax is taking over and the actions here should get migrated from HCL to YAML syntax when possible.

https://help.github.com/en/articles/migrating-github-actions-from-hcl-syntax-to-yaml-syntax

@sc0ttkclark sc0ttkclark added the type:enhancement New feature or request. label Aug 20, 2019
@helen
Copy link
Collaborator

helen commented Aug 20, 2019

Thanks for opening this issue @sc0ttkclark - I'm working on making sure we use the actual tag action instead of just push, previously only push was enabled for public repos but that's since changed so I want to update this wholesale!

@sc0ttkclark
Copy link
Author

:dance-attack: thanks!

@2ndkauboy
Copy link

I've just used your GitHub action yesterday and had to migrate the HCL files to the YAML syntax. I used the migration tool from GitHub. You can find the YAML files here: https://github.com/2ndkauboy/SyntaxHighlighter-Evolved-SASS-Brush/tree/master/.github/workflows

@helen
Copy link
Collaborator

helen commented Aug 21, 2019

@sc0ttkclark @2ndkauboy If y'all have a moment, would appreciate any thoughts on the correctness and readability of #20 :)

@helen helen closed this as completed in #20 Aug 21, 2019
helen added a commit that referenced this issue Aug 21, 2019
@2ndkauboy
Copy link

Looks good to me!

@2ndkauboy
Copy link

I just checked your new YAML files with my plugin by updating only the readme and it looks really good. Only the readme/assets action fired and was successful! 🙌

@helen
Copy link
Collaborator

helen commented Aug 29, 2019

@2ndkauboy @sc0ttkclark You will probably want to update the plugin deploy workflow to use the new/improved tag filtering syntax, I've updated the documentation here: https://github.com/10up/action-wordpress-plugin-deploy

@sc0ttkclark
Copy link
Author

Just ran this successfully. In my case, I didn't have any npm build process that needed to run so it would fail to deploy because of npm errors. Once I removed that section it ran perfectly.

@sc0ttkclark
Copy link
Author

I should note that this was probably the fastest deploy I've ever done! Not talking about steps (we had automation before) but in terms of SVN this whole process ran for 1m 38s, which only 30s was SVN. That's awesome, thank you very much for helping speed up my workflow! :)

@helen
Copy link
Collaborator

helen commented Sep 5, 2019

@sc0ttkclark Yay!!! We are actually discussing documentation of multiple examples over in 10up/action-wordpress-plugin-deploy#5 - I am worried about exactly what you experienced, which is that as people are getting these things set up for the first time, they won't quite understand that they may need to remove stuff from the sample workflow file, so maybe it should be a barebones example and link off to more examples in a separate document.

@sc0ttkclark
Copy link
Author

Yeah I like that idea, knowing the easy syntax to include npm processes is super handy to know how to put the two together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants