fix: Fix http image registry edit exception (#9460)

ssongliu · web-flow · commit 0d548c7df9a3 · 2025-07-08T18:18:00.000+08:00
diff --git a/backend/app/service/image_repo.go b/backend/app/service/image_repo.go
@@ -155,10 +155,12 @@ func (u *ImageRepoService) Update(req dto.ImageRepoUpdate) error {
 		needRestart = true
 	}
 	if repo.Protocol == "http" && req.Protocol == "http" {
-		if err := u.handleRegistries(req.DownloadUrl, repo.DownloadUrl, "update"); err != nil {
-			return fmt.Errorf("update registry %s => %s failed, err: %v", repo.DownloadUrl, req.DownloadUrl, err)
+		if repo.DownloadUrl != req.DownloadUrl {
+			if err := u.handleRegistries(req.DownloadUrl, repo.DownloadUrl, "update"); err != nil {
+				return fmt.Errorf("update registry %s => %s failed, err: %v", repo.DownloadUrl, req.DownloadUrl, err)
+			}
+			needRestart = true
 		}
-		needRestart = repo.DownloadUrl == req.DownloadUrl
 	}
 	if repo.Protocol == "https" && req.Protocol == "http" {
 		if err := u.handleRegistries(req.DownloadUrl, "", "create"); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -155,10 +155,12 @@ func (u *ImageRepoService) Update(req dto.ImageRepoUpdate) error {`
`155`	`155`	`needRestart = true`
`156`	`156`	`}`
`157`	`157`	`if repo.Protocol == "http" && req.Protocol == "http" {`
`158`		`- if err := u.handleRegistries(req.DownloadUrl, repo.DownloadUrl, "update"); err != nil {`
`159`		`- return fmt.Errorf("update registry %s => %s failed, err: %v", repo.DownloadUrl, req.DownloadUrl, err)`
	`158`	`+ if repo.DownloadUrl != req.DownloadUrl {`
	`159`	`+ if err := u.handleRegistries(req.DownloadUrl, repo.DownloadUrl, "update"); err != nil {`
	`160`	`+ return fmt.Errorf("update registry %s => %s failed, err: %v", repo.DownloadUrl, req.DownloadUrl, err)`
	`161`	`+ }`
	`162`	`+ needRestart = true`
`160`	`163`	`}`
`161`		`- needRestart = repo.DownloadUrl == req.DownloadUrl`
`162`	`164`	`}`
`163`	`165`	`if repo.Protocol == "https" && req.Protocol == "http" {`
`164`	`166`	`if err := u.handleRegistries(req.DownloadUrl, "", "create"); err != nil {`