Skip to content

fix: remove_form_rander #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

shaohuzhang1
Copy link
Contributor

fix: remove_form_rander

Copy link

f2c-ci-robot bot commented Apr 2, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit e364d6e into main Apr 2, 2025
4 checks passed
@@ -111,7 +111,7 @@ const copy = (data: any) => {
const text = data.answer_text_list
.map((item: Array<any>) => item.map((i) => i.content).join('\n'))
.join('\n\n')
copyClick(text)
copyClick(removeFormRander(text))
} catch (e: any) {
copyClick(removeFormRander(data?.answer_text.trim()))
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appears to have a logical mistake. In the copy function, it calls copyClick(text) instead of copyClick(removeFormRander(text)).

To ensure that form rendering is stripped from the copied string before copying, the correct line should be:

copyClick(removeFormRander(text));

This would prevent unwanted HTML content from being included in the copied output.

No further optimizations or issues were identified with the provided code snippet at this time. If you need additional functionality adjustments, feel free to ask!

@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_remove_form_rander branch April 2, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant