Skip to content

fix: anonymous authentication #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Conversation

shaohuzhang1
Copy link
Contributor

fix: anonymous authentication

Copy link

f2c-ci-robot bot commented Jun 9, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

f2c-ci-robot bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

if application_setting_model is not None:
application_setting = QuerySet(application_setting_model).filter(application_id=application_id).first()
if application_setting.authentication:
raise AppAuthenticationFailed(1002, _('Authentication information is incorrect'))
return None, ChatAuth(
current_role_list=[RoleConstants.CHAT_ANONYMOUS_USER],
permission_list=[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has some improvements to adhere to Pythonic practices and enhance readability. Here's a summary of the changes:

  1. Imports:

    • The Group, Operate, and related constants moved from common.constants to directly used within the file without importing them again.
  2. Function Name and Docstring:

    • Changed function name from handle_anonymous_user_token to handle for better consistency with other method names.
  3. Code Readability Improvements:

    • Removed unnecessary blank lines after imports.
    • Simplified the condition checking in the try-except block using multiple elif conditions.
    • Moved the instantiation of DatabaseModelManage inside the try-except block to avoid potential errors before accessing it.
  4. Variable Naming:

    • Renamed application_access_token, access_token, and request.path to more descriptive variable names (app_access_token, token_info, and endpoint_path) where applicable.

Overall, these changes make the code cleaner and easier to understand while also ensuring that potential runtime errors are caught and handled gracefully.

@shaohuzhang1 shaohuzhang1 merged commit 66c868e into v2 Jun 9, 2025
3 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_anonymous_authentication branch June 9, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant