Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return type hint for load_dict #67

Open
kthy opened this issue Feb 14, 2023 · 1 comment
Open

Wrong return type hint for load_dict #67

kthy opened this issue Feb 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kthy
Copy link

kthy commented Feb 14, 2023

  • SDK Version: 1.3.0
  • Connect Server Version: 1.6.0
  • OS: ubuntu-22.04
  • Python Version: 3.10

What happened?

The type hint for the return value of load_dict is Dict[str, str] (as stated in config.py line 60) but the actual return type is dict[str, str | None], or dict[str, Optional[str]] if you prefer.

How to reproduce

Add a text field with no value to an item in 1Password. It will not be shown in the client, but when you click Edit you can see it is still there; you can also verify this with e.g. curl.

Then call load_dict and you will see that the value of the field is None.

@kthy kthy added the bug Something isn't working label Feb 14, 2023
@volodymyrZotov
Copy link
Contributor

Hi @kthy👋. Thank you very much for reporting this!
We're going to take a look and fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants