Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_client_from_environment() is missing 'token' argument #88

Open
mjpieters opened this issue Oct 6, 2023 · 0 comments
Open

new_client_from_environment() is missing 'token' argument #88

mjpieters opened this issue Oct 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mjpieters
Copy link
Contributor

The docstring for client.new_client_from_environment() states it takes a token argument:

    Parameters:
    url: The url of the 1Password Connect API
    token: The 1Password Service Account token

but there is no token argument, only a url argument. Either update the documentation or add the argument to the function.
@mjpieters mjpieters added the bug Something isn't working label Oct 6, 2023
melwil added a commit to melwil/connect-sdk-python that referenced this issue Oct 23, 2023
@melwil
Remove token from create from env doc. Fixes 1Password#88.
6346030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjpieters