Skip to content

Commit 740391e

Browse files
committed
Remove unused expiry variable (expiration managed in makertraits)
1 parent 85f5250 commit 740391e

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed

sdk-clients/orderbook/examples/create_order/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ func main() {
7777
createOrderResponse, err := client.CreateOrder(ctx, orderbook.CreateOrderParams{
7878
Wallet: client.Wallet,
7979
SeriesNonce: seriesNonce,
80-
ExpireAfterUnix: expireAfter,
8180
Maker: publicAddress.Hex(),
8281
MakerAsset: wmatic,
8382
TakerAsset: usdc,

sdk-clients/orderbook/orderbook_types_manual.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ type CreateOrderParams struct {
1414
MakerTraits *MakerTraits
1515
Extension Extension
1616
ExtensionEncoded string
17-
ExpireAfterUnix int64
1817
Maker string
1918
MakerAsset string
2019
TakerAsset string

sdk-clients/orderbook/validate.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ func (params *CreateOrderParams) Validate() error {
1111
var validationErrors []error
1212
// validationErrors = validate.Parameter(params.SeriesNonce, "seriesNonce", validate.CheckBigIntRequired, validationErrors) // TODO All other places expect a string value for raw request parameters, but this value will always come in as a big.Int because of the onchain nature of retrieving it
1313
validationErrors = validate.Parameter(params.Maker, "maker", validate.CheckEthereumAddressRequired, validationErrors)
14-
validationErrors = validate.Parameter(params.ExpireAfterUnix, "expireAfter", validate.CheckExpireAfterUnix, validationErrors)
1514
validationErrors = validate.Parameter(params.MakerAsset, "makerAsset", validate.CheckEthereumAddressRequired, validationErrors)
1615
validationErrors = validate.Parameter(params.TakerAsset, "takerAsset", validate.CheckEthereumAddressRequired, validationErrors)
1716
validationErrors = validate.Parameter(params.TakingAmount, "takingAmount", validate.CheckBigIntRequired, validationErrors)

0 commit comments

Comments
 (0)