feature: @putout/plugin-remove-useless-contiue: remove only ContinueStatement

Author: coderaiser

packages/plugin-convert-for-each-to-for-of/package.json

@@ -31,6 +31,7 @@
   "devDependencies": {
     "@putout/plugin-convert-comparison-to-boolean": "*",
     "@putout/plugin-convert-const-to-let": "*",
+    "@putout/plugin-remove-useless-continue": "*",
     "@putout/plugin-remove-useless-variables": "*",
     "@putout/test": "^5.0.0",
     "c8": "^7.5.0",

packages/plugin-convert-for-each-to-for-of/test/convert-for-each-to-for-of.js

@@ -6,6 +6,7 @@ const convertForEachToForOf = require('..');
 const convertComparisonToBoolean = require('@putout/plugin-convert-comparison-to-boolean');
 const removeUselessVariables = require('@putout/plugin-remove-useless-variables');
 const convertConstToLet = require('@putout/plugin-convert-const-to-let');
+const removeUselessContinue = require('@putout/plugin-remove-useless-continue');
 
 const test = createTest(__dirname, {
     'convert-for-each-to-for-of': convertForEachToForOf,
@@ -106,6 +107,13 @@ test('plugin-convert-for-each-to-for-of: transform: this i', (t) => {
     t.end();
 });
 
+test('plugin-convert-for-each-to-for-of: transform: end-return', (t) => {
+    t.transform('end-return', {
+        'remove-useless-continue': removeUselessContinue,
+    });
+    t.end();
+});
+
 test('plugin-convert-for-each-to-for-of: transform: not-constant', (t) => {
     t.transform('not-const', {
         convertConstToLet,

packages/plugin-convert-for-each-to-for-of/test/fixture/end-return-fix.js

@@ -0,0 +1,7 @@
+let a = 0;
+
+for (const b of list) {
+    a += b;
+    a;
+}
+

packages/plugin-convert-for-each-to-for-of/test/fixture/end-return.js

@@ -0,0 +1,7 @@
+let a = 0;
+
+list.forEach((b) => {
+    a += b;
+    return a;
+});
+

packages/plugin-remove-useless-continue/lib/remove-useless-continue.js

@@ -1,13 +1,15 @@
 'use strict';
 
-const {EmptyElement} = require('putout').types;
+const {operator} = require('putout');
+
+const {remove} = operator;
 
 const isLoop = (path) => path.isLoop() || path.parentPath.isLoop();
 
-module.exports.report = () => 'Useless continue should be avoided';
+module.exports.report = () => `Avoid useless 'continue'`;
 
 module.exports.fix = (path) => {
-    path.parentPath.node.body = EmptyElement;
+    remove(path);
 };
 
 module.exports.traverse = ({push}) => ({
@@ -23,7 +25,7 @@ module.exports.traverse = ({push}) => ({
         }
 
         if (parentPath.isBlockStatement()) {
-            push(parentPath);
+            push(path);
             return;
         }
     },

packages/plugin-remove-useless-continue/test/fixture/continue-fix.js

@@ -1,12 +1,11 @@
-for (i = 0; i < 5; i++)
-    ;
+for (i = 0; i < 5; i++) {}
 
 for (i = 0; i < 5; i++)
-    ;
+    {}
 
 while (x)
-    ;
+    {}
 
 for (const a of [])
-    ;
+    {}
 

packages/plugin-remove-useless-continue/test/fixture/for-of-fix.js

@@ -0,0 +1,7 @@
+let a = 0;
+
+for (const b of list) {
+    a += b;
+}
+
+fn(a);

packages/plugin-remove-useless-continue/test/fixture/for-of.js

@@ -0,0 +1,8 @@
+let a = 0;
+
+for (const b of list) {
+    a += b;
+    continue;
+}
+
+fn(a);

packages/plugin-remove-useless-continue/test/remove-useless-continue.js

@@ -8,7 +8,7 @@ const test = createTest(__dirname, {
 });
 
 test('plugin-remove-useless-continue: report', (t) => {
-    t.report('continue', 'Useless continue should be avoided');
+    t.report('continue', `Avoid useless 'continue'`);
     t.end();
 });
 
@@ -22,6 +22,11 @@ test('plugin-remove-useless-continue: transform', (t) => {
     t.end();
 });
 
+test('plugin-remove-useless-continue: transform: for-of', (t) => {
+    t.transform('for-of');
+    t.end();
+});
+
 test('plugin-remove-useless-continue: no transform: no-continue', (t) => {
     t.noTransform('no-continue');
     t.end();