reworked address join from main export query

Author: clausnagel

citydb-database-postgres/src/main/resources/org/citydb/database/postgres/query_feature_hierarchy.sql

@@ -57,7 +57,7 @@ WITH RECURSIVE FEATURE_HIERARCHY AS
    FROM @[email protected] P
    INNER JOIN FEATURE_HIERARCHY H ON H.VAL_FEATURE_ID = P.FEATURE_ID AND H.VAL_RELATION_TYPE = 1
    WHERE NOT IS_CYCLE)
-SELECT DISTINCT ON (H.ID)
+SELECT
   H.ID,
   H.FEATURE_ID,
   H.PARENT_ID,
@@ -97,22 +97,7 @@ SELECT DISTINCT ON (H.ID)
   F.VALID_TO,
   {} AS GEOMETRY,
   G.GEOMETRY_PROPERTIES,
-  G.FEATURE_ID AS GEOMETRY_FEATURE_ID,
-  A.OBJECTID AS ADDRESS_OBJECTID,
-  A.IDENTIFIER AS ADDRESS_IDENTIFIER,
-  A.IDENTIFIER_CODESPACE AS ADDRESS_IDENTIFIER_CODESPACE,
-  A.STREET,
-  A.HOUSE_NUMBER,
-  A.PO_BOX,
-  A.ZIP_CODE,
-  A.CITY,
-  A.STATE,
-  A.COUNTRY,
-  A.FREE_TEXT,
-  {} AS MULTI_POINT,
-  A.CONTENT,
-  A.CONTENT_MIME_TYPE
+  G.FEATURE_ID AS GEOMETRY_FEATURE_ID
 FROM FEATURE_HIERARCHY H
 LEFT JOIN @[email protected] F ON F.ID = H.VAL_FEATURE_ID
 LEFT JOIN @[email protected]_DATA G ON G.ID = H.VAL_GEOMETRY_ID
-LEFT JOIN @[email protected] A ON A.ID = H.VAL_ADDRESS_ID

citydb-database/src/main/java/org/citydb/database/util/IndexHelper.java

@@ -53,7 +53,6 @@ public class IndexHelper {
             Index.PROPERTY_VAL_TIMESTAMP,
             Index.PROPERTY_VAL_DOUBLE,
             Index.PROPERTY_VAL_INT,
-            Index.PROPERTY_VAL_LOD,
             Index.PROPERTY_VAL_STRING,
             Index.PROPERTY_VAL_UOM,
             Index.PROPERTY_VAL_URI));

citydb-operation/src/main/java/org/citydb/operation/exporter/address/AddressExporter.java

@@ -33,54 +33,84 @@
 
 import java.sql.ResultSet;
 import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Collections;
+import java.util.HashMap;
 import java.util.Map;
+import java.util.Set;
 
 public class AddressExporter extends DatabaseExporter {
+    private final Table address;
+    private final Select select;
 
     public AddressExporter(ExportHelper helper) throws SQLException {
         super(helper);
-        stmt = helper.getConnection().prepareStatement(getQuery().toSql());
+        address = tableHelper.getTable(org.citydb.database.schema.Table.ADDRESS);
+        select = getBaseQuery();
+        stmt = helper.getConnection().prepareStatement(Select.of(select)
+                .where(address.column("id").eq(Placeholder.empty()))
+                .toSql());
     }
 
-    private Select getQuery() {
-        Table address = tableHelper.getTable(org.citydb.database.schema.Table.ADDRESS);
+    private Select getBaseQuery() {
         return Select.newInstance()
-                .select(address.columns(Map.of("objectid", "address_objectid", "identifier", "address_identifier",
-                        "identifier_codespace", "address_identifier_codespace")))
-                .select(address.columns("street", "house_number", "po_box", "zip_code", "city",
-                        "state", "country", "free_text", "content", "content_mime_type"))
+                .select(address.columns("id", "objectid", "identifier", "identifier_codespace", "street",
+                        "house_number", "po_box", "zip_code", "city", "state", "country", "free_text", "content",
+                        "content_mime_type"))
                 .select(helper.getTransformOperator(address.column("multi_point")))
-                .from(address)
-                .where(address.column("id").eq(Placeholder.empty()));
+                .from(address);
+    }
+
+    private Select getQuery(Set<Long> ids) {
+        return Select.of(select)
+                .where(operationHelper.in(address.column("id"), ids));
     }
 
     public Address doExport(long id) throws ExportException, SQLException {
         stmt.setLong(1, id);
         try (ResultSet rs = stmt.executeQuery()) {
-            if (rs.next()) {
-                return doExport(id, rs);
-            }
+            return doExport(rs).get(id);
         }
+    }
 
-        return null;
+    public Map<Long, Address> doExport(Set<Long> ids) throws ExportException, SQLException {
+        if (ids.size() == 1) {
+            stmt.setLong(1, ids.iterator().next());
+            try (ResultSet rs = stmt.executeQuery()) {
+                return doExport(rs);
+            }
+        } else if (!ids.isEmpty()) {
+            try (Statement stmt = helper.getConnection().createStatement();
+                 ResultSet rs = stmt.executeQuery(getQuery(ids).toSql())) {
+                return doExport(rs);
+            }
+        } else {
+            return Collections.emptyMap();
+        }
     }
 
-    public Address doExport(long addressId, ResultSet rs) throws ExportException, SQLException {
-        return Address.newInstance()
-                .setObjectId(rs.getString("address_objectid"))
-                .setIdentifier(rs.getString("address_identifier"))
-                .setIdentifierCodeSpace(rs.getString("address_identifier_codespace"))
-                .setStreet(rs.getString("street"))
-                .setHouseNumber(rs.getString("house_number"))
-                .setPoBox(rs.getString("po_box"))
-                .setZipCode(rs.getString("zip_code"))
-                .setCity(rs.getString("city"))
-                .setState(rs.getString("state"))
-                .setCountry(rs.getString("country"))
-                .setFreeText(getArrayValue(rs.getString("free_text")))
-                .setMultiPoint(getGeometry(rs.getObject("multi_point"), MultiPoint.class))
-                .setGenericContent(rs.getString("content"))
-                .setGenericContentMimeType(rs.getString("content_mime_type"))
-                .setDescriptor(AddressDescriptor.of(addressId));
+    private Map<Long, Address> doExport(ResultSet rs) throws ExportException, SQLException {
+        Map<Long, Address> addresses = new HashMap<>();
+        while (rs.next()) {
+            long id = rs.getLong("id");
+            addresses.put(id, Address.newInstance()
+                    .setObjectId(rs.getString("objectid"))
+                    .setIdentifier(rs.getString("identifier"))
+                    .setIdentifierCodeSpace(rs.getString("identifier_codespace"))
+                    .setStreet(rs.getString("street"))
+                    .setHouseNumber(rs.getString("house_number"))
+                    .setPoBox(rs.getString("po_box"))
+                    .setZipCode(rs.getString("zip_code"))
+                    .setCity(rs.getString("city"))
+                    .setState(rs.getString("state"))
+                    .setCountry(rs.getString("country"))
+                    .setFreeText(getArrayValue(rs.getString("free_text")))
+                    .setMultiPoint(getGeometry(rs.getObject("multi_point"), MultiPoint.class))
+                    .setGenericContent(rs.getString("content"))
+                    .setGenericContentMimeType(rs.getString("content_mime_type"))
+                    .setDescriptor(AddressDescriptor.of(id)));
+        }
+
+        return addresses;
     }
 }

citydb-operation/src/main/java/org/citydb/operation/exporter/geometry/ImplicitGeometryExporter.java

@@ -95,7 +95,12 @@ public ImplicitGeometry doExport(long id) throws ExportException, SQLException {
     }
 
     public Map<Long, ImplicitGeometry> doExport(Set<Long> ids, Collection<Appearance> appearances) throws ExportException, SQLException {
-        if (!ids.isEmpty()) {
+        if (ids.size() == 1) {
+            stmt.setLong(1, ids.iterator().next());
+            try (ResultSet rs = stmt.executeQuery()) {
+                return doExport(appearances, rs);
+            }
+        } else if (!ids.isEmpty()) {
             try (Statement stmt = helper.getConnection().createStatement();
                  ResultSet rs = stmt.executeQuery(getQuery(ids).toSql())) {
                 return doExport(appearances, rs);

citydb-operation/src/main/java/org/citydb/operation/exporter/hierarchy/HierarchyBuilder.java

@@ -69,6 +69,7 @@ public static HierarchyBuilder newInstance(long rootId, ExportHelper helper) {
 
     public HierarchyBuilder initialize(ResultSet rs) throws ExportException, SQLException {
         Set<Long> appearanceIds = new HashSet<>();
+        Set<Long> addressIds = new HashSet<>();
         Set<Long> implicitGeometryIds = new HashSet<>();
 
         while (rs.next()) {
@@ -94,9 +95,8 @@ public HierarchyBuilder initialize(ResultSet rs) throws ExportException, SQLExce
             }
 
             long addressId = rs.getLong("val_address_id");
-            if (!rs.wasNull() && hierarchy.getAddress(addressId) == null) {
-                hierarchy.addAddress(addressId, tableHelper.getOrCreateExporter(AddressExporter.class)
-                        .doExport(addressId, rs));
+            if (!rs.wasNull()) {
+                addressIds.add(addressId);
             }
 
             long implicitGeometryId = rs.getLong("val_implicitgeom_id");
@@ -114,15 +114,23 @@ public HierarchyBuilder initialize(ResultSet rs) throws ExportException, SQLExce
             }
         }
 
-        if (exportAppearances) {
+        if (exportAppearances && !appearanceIds.isEmpty()) {
             tableHelper.getOrCreateExporter(AppearanceExporter.class)
                     .doExport(appearanceIds, implicitGeometryIds)
                     .forEach(hierarchy::addAppearance);
         }
 
-        tableHelper.getOrCreateExporter(ImplicitGeometryExporter.class)
-                .doExport(implicitGeometryIds, hierarchy.getAppearances().values())
-                .forEach(hierarchy::addImplicitGeometry);
+        if (!addressIds.isEmpty()) {
+            tableHelper.getOrCreateExporter(AddressExporter.class)
+                    .doExport(addressIds)
+                    .forEach(hierarchy::addAddress);
+        }
+
+        if (!implicitGeometryIds.isEmpty()) {
+            tableHelper.getOrCreateExporter(ImplicitGeometryExporter.class)
+                    .doExport(implicitGeometryIds, hierarchy.getAppearances().values())
+                    .forEach(hierarchy::addImplicitGeometry);
+        }
 
         return this;
     }