Skip to content

Commit f86248f

Browse files
committedJul 18, 2024
Hihat pedal: only trigger when it's absolutely closed
This makes pedal stomps caused by half-open hihat play less likely. Also increase the various hihat ranges so that they can be used more easily. Fixes corrados#145
1 parent 6faff07 commit f86248f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed
 

‎pad.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ class Pad
207207

208208
// definitions which can be used outside the pad class, too
209209
static const int control_midi_hysteresis = ADC_MAX_NOISE_AMPL / 2; // MIDI hysteresis for the controller to suppress noise
210-
static const int hi_hat_is_open_MIDI_threshold = 100; // MIDI values smaller than the limit value are "open hi-hat"
210+
static const int hi_hat_is_open_MIDI_threshold = 122; // MIDI values smaller than the limit value are "open hi-hat"
211211

212212
protected:
213213
struct Epadsettings

‎tools/create_drumgizmo_kit.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@
4848
instruments = [["kick", ["KDrum", "OHLeft", "OHRight"], [36], "", "", 0.1, 15], \
4949
["snare", ["Snare", "OHLeft", "OHRight"], [38], "", "", 0.08, 16], \
5050
["snare_rimshot", ["Snare", "OHLeft", "OHRight"], [40], "", "", 0.3, 15], \
51-
["hihat_closed", ["Hihat", "OHLeft", "OHRight"], [22, 26], "hihat", "80", 0.18, 20], \
52-
["hihat_closedtop", ["Hihat", "OHLeft", "OHRight"], [42, 46], "hihat", "80", 0.2, 20], \
51+
["hihat_closed", ["Hihat", "OHLeft", "OHRight"], [22, 26], "hihat", "122",0.18, 20], \
52+
["hihat_closedtop", ["Hihat", "OHLeft", "OHRight"], [42, 46], "hihat", "122",0.2, 20], \
5353
["hihat_open", ["Hihat", "OHLeft", "OHRight"], [26], "hihat", "0", 0.7, 23], \
54-
["hihat_open1", ["Hihat", "OHLeft", "OHRight"], [26], "hihat", "55", 0.7, 23], \
55-
["hihat_open2", ["Hihat", "OHLeft", "OHRight"], [26], "hihat", "27", 0.7, 23], \
54+
["hihat_open1", ["Hihat", "OHLeft", "OHRight"], [26], "hihat", "80", 0.7, 23], \
55+
["hihat_open2", ["Hihat", "OHLeft", "OHRight"], [26], "hihat", "30", 0.7, 23], \
5656
["hihat_opentop", ["Hihat", "OHLeft", "OHRight"], [46], "hihat", "0", 0.7, 24], \
57-
["hihat_open1top", ["Hihat", "OHLeft", "OHRight"], [46], "hihat", "55", 0.7, 21], \
58-
["hihat_open2top", ["Hihat", "OHLeft", "OHRight"], [46], "hihat", "27", 0.7, 23], \
57+
["hihat_open1top", ["Hihat", "OHLeft", "OHRight"], [46], "hihat", "80", 0.7, 21], \
58+
["hihat_open2top", ["Hihat", "OHLeft", "OHRight"], [46], "hihat", "30", 0.7, 23], \
5959
["hihat_foot", ["Hihat", "OHLeft", "OHRight"], [44], "hihat", "", 0.1, 23], \
6060
["tom1", ["Tom1", "OHLeft", "OHRight"], [48, 50], "", "", 0.2, 15], \
6161
["tom2", ["Tom2", "OHLeft", "OHRight"], [45, 47], "", "", 0.2, 15], \

0 commit comments

Comments
 (0)
Please sign in to comment.