Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test not failing the build #12

Open
mathbruyen opened this issue May 23, 2014 · 1 comment
Open

Failing test not failing the build #12

mathbruyen opened this issue May 23, 2014 · 1 comment

Comments

@mathbruyen
Copy link
Member

From travis build:

1) Stream resolver generates difference:

Error: timeout of 2000ms exceeded
at null.<anonymous> (/home/travis/build/3musket33rs/mathsync/javascript/core/node_modules/mocha/lib/runnable.js:139:19)
at Timer.listOnTimeout (timers.js:133:15)
@mathbruyen
Copy link
Member Author

Build fails for tests in error when adding

gulp.on('err', function () {
  process.exit(1);
});

at the end of gulpfile.js. err looks strange as usually error is used.

Then the problem is related to jshint, even with fail reporter build is always successful. Only way found up to now:

.pipe(jshint.reporter('fail')).on('error', process.exit.bind(process, 1))

does the trick.

But it starts to be ugly. The root cause seems the way to call gulp through node, with harmony flag set for one test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant