Skip to content

feat/workload-health #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged

feat/workload-health #29

merged 3 commits into from
Jun 4, 2025

Conversation

roivaz
Copy link
Contributor

@roivaz roivaz commented Jun 3, 2025

Implements health for status reconciliation feature:

  • Per deployment/statefulset health calculation
  • Aggregated health calculation across all deployments/statefulsets owned by the custom resource
  • Documents status reconciliation feature
  • Adds health calculation unit test

/kind feature
/priority important-soon
/assign

roivaz added 2 commits June 3, 2025 12:44
For workload composed of several Deployments/StatefulSets, calculate
health and show it in the status of the custom resource. Much of the
code has been borrowed from https://github.com/argoproj/gitops-engine/blob/master/pkg/health/health.go
@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. wg/sre Categorizes issue or PR as related to the SRE working group. labels Jun 3, 2025
@3scale-robot 3scale-robot requested a review from raelga June 3, 2025 12:39
@3scale-robot 3scale-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. label Jun 3, 2025
@3scale-robot 3scale-robot requested a review from slopezz June 3, 2025 12:39
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jun 3, 2025
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2025
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d7bf9b7a97ac78fef4a8dc05301fe0e56e4324e

Copy link
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roivaz
Copy link
Contributor Author

roivaz commented Jun 4, 2025

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
@3scale-robot 3scale-robot merged commit e4107ba into main Jun 4, 2025
6 checks passed
@3scale-robot 3scale-robot deleted the feat/workload-health branch June 4, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/L Requires few days to complete the PR or the issue. wg/sre Categorizes issue or PR as related to the SRE working group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants