Commit 343a25b
[SPARK-53868][SQL] Use array length check instead of direct reference check in V2ExpressionBuilder
### What changes were proposed in this pull request?
apache#52573 here I did a slight refactor to `visitAggregate`, but I used direct reference check to compare arrays, this works as it's the same reference, but we should make the check more generic to any empty array.
### Why are the changes needed?
If someone were to use different reference in CountStar it would fail, which is not the best behavior as any empty array shuold work.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing tests
### Was this patch authored or co-authored using generative AI tooling?
No
Closes apache#52587 from alekjarmov/improve-check.
Authored-by: alekjarmov <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>1 parent 264ca4d commit 343a25b
File tree
1 file changed
+1
-1
lines changed- sql/catalyst/src/main/java/org/apache/spark/sql/connector/util
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
290 | | - | |
| 290 | + | |
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
| |||
0 commit comments