Enum values are now checked in json.Unmarshal

[ianling]

Checking enum values and returning an error if they are not valid during json.Unmarshal is a breaking change. Specifically, json.Unmarshal was not previously calling e.UnmarshalGQL(s), which contains the additional check for valid enum values.

The commit: eed4a10 (plugin/modelgen/models.gotpl)

I understand the GraphQL spec requires enums to always contain valid values, and gqlgen is technically released under a 0.x.x semantic version, so breaking changes may be released at any time. We were unfortunately relying on the non-spec-compliant behavior in our application.

Could I add a config option to gqlgen that optionally disables the enum value checks?

[gabrielbovilorandi]

That would be great, yeah!

[StevenACoffman]

Sure. I'm always happy to merge to PRs to opt out of behavior like this, especially if you leave the code better than you found it. This project is maintained as an unpaid volunteer community effort. If there's ever anything else you want to improve or add, please just open a PR. I try to monitor to those closely and react quickly, but I really can't keep up with the deluge of issues alone (and I usually wouldn't have noticed this one).

Note

As far as backward compatibility goes, we have tried not to break backward compatibility, or to at least allow people to opt in or opt out when we do need to. The GraphQL spec itself does not always follow the reference implementation (which is the true spec) and that tends to subtly break "compatibility" on the regular. The GraphQL spec and JavaScript reference implementation maintainers have never had much interest in engaging with other programming languages, or resolving ambiguities that result in the differences between them.

I have reacted to this discovery by changing gqlparser/v2 to run the GraphQL JavaScript reference implementation's tests as part of the gqlparser tests.

I think we should do the same thing for gqlgen, but that's an effort that I haven't been able to devote time to (but would greatly appreciate PRs for even the first steps towards!)

But, ignoring my minor rant above, I would love to get a PR to add a config option so folks can opt out of this behavior and allow people to more gently choose when and if they get more GraphQL compliant with this.