Skip to content

Commit c89e9dd

Browse files
committed
Merge branch 'release/v3.5.0'
2 parents bec21d2 + c53732a commit c89e9dd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+2426
-150
lines changed

Dockerfile

+12-3
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,24 @@
11
FROM ubuntu:20.04
22

3-
RUN apt-get -qq update && apt-get install -yq \
4-
python3-pip \
5-
python3-dev \
3+
RUN apt-get -qq update \
4+
&& DEBIAN_FRONTEND=noninteractive apt-get install -yq \
5+
bcftools \
66
curl \
7+
python3-dev \
8+
python3-pip \
9+
samtools \
10+
tabix \
11+
vcftools \
12+
wget \
713
&& \
814
rm -rf /var/lib/apt/lists/*
915

1016
ADD . /opt/truvari-source
1117
WORKDIR /opt/truvari-source
1218

19+
RUN wget https://mafft.cbrc.jp/alignment/software/mafft_7.505-1_amd64.deb \
20+
&& dpkg -i mafft_7.505-1_amd64.deb && rm mafft_7.505-1_amd64.deb
21+
1322
RUN python3 -m pip install --upgrade pip && \
1423
python3 -m pip install setproctitle pylint anybadge coverage && \
1524
python3 -m pip install --upgrade setuptools && \

docs/api/truvari.rst

+8
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,10 @@ get_svtype
140140
^^^^^^^^^^
141141
.. autofunction:: get_svtype
142142

143+
msa2vcf
144+
^^^^^^^
145+
.. autofunction:: msa2vcf
146+
143147
overlap_percent
144148
^^^^^^^^^^^^^^^
145149
.. autofunction:: overlap_percent
@@ -148,6 +152,10 @@ overlaps
148152
^^^^^^^^
149153
.. autofunction:: overlaps
150154

155+
phab
156+
^^^^
157+
.. autofunction:: phab
158+
151159
reciprocal_overlap
152160
^^^^^^^^^^^^^^^^^^
153161
.. autofunction:: reciprocal_overlap

docs/v3.5.0/Citations.md

+31
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# Citing Truvari
2+
3+
Pre-print on Biorxiv while in submission:
4+
5+
Truvari: Refined Structural Variant Comparison Preserves Allelic Diversity
6+
doi: https://doi.org/10.1101/2022.02.21.481353
7+
8+
# Citations
9+
10+
List of publications using Truvari. Most of these are just pulled from a [Google Scholar Search](https://scholar.google.com/scholar?q=truvari). Please post in the [show-and-tell](https://github.com/spiralgenetics/truvari/discussions/categories/show-and-tell) to have your publication added to the list.
11+
* [A robust benchmark for detection of germline large deletions and insertions](https://www.nature.com/articles/s41587-020-0538-8)
12+
* [Leveraging a WGS compression and indexing format with dynamic graph references to call structural variants](https://www.biorxiv.org/content/10.1101/2020.04.24.060202v1.abstract)
13+
* [Duphold: scalable, depth-based annotation and curation of high-confidence structural variant calls](https://academic.oup.com/gigascience/article/8/4/giz040/5477467?login=true)
14+
* [Parliament2: Accurate structural variant calling at scale](https://academic.oup.com/gigascience/article/9/12/giaa145/6042728)
15+
* [Learning What a Good Structural Variant Looks Like](https://www.biorxiv.org/content/10.1101/2020.05.22.111260v1.full)
16+
* [Long-read trio sequencing of individuals with unsolved intellectual disability](https://www.nature.com/articles/s41431-020-00770-0)
17+
* [lra: A long read aligner for sequences and contigs](https://journals.plos.org/ploscompbiol/article?id=10.1371/journal.pcbi.1009078)
18+
* [Samplot: a platform for structural variant visual validation and automated filtering](https://genomebiology.biomedcentral.com/articles/10.1186/s13059-021-02380-5)
19+
* [AsmMix: A pipeline for high quality diploid de novo assembly](https://www.biorxiv.org/content/10.1101/2021.01.15.426893v1.abstract)
20+
* [Accurate chromosome-scale haplotype-resolved assembly of human genomes](https://www.nature.com/articles/s41587-020-0711-0)
21+
* [Accurate circular consensus long-read sequencing improves variant detection and assembly of a human genome](https://www.nature.com/articles/s41587-019-0217-9)
22+
* [NPSV: A simulation-driven approach to genotyping structural variants in whole-genome sequencing data](https://academic.oup.com/bioinformatics/article-abstract/37/11/1497/5466452)
23+
* [SVIM-asm: structural variant detection from haploid and diploid genome assemblies](https://academic.oup.com/bioinformatics/article/36/22-23/5519/6042701?login=true)
24+
* [Readfish enables targeted nanopore sequencing of gigabase-sized genomes](https://www.nature.com/articles/s41587-020-00746-x)
25+
* [stLFRsv: A Germline Structural Variant Analysis Pipeline Using Co-barcoded Reads](https://internal-journal.frontiersin.org/articles/10.3389/fgene.2021.636239/full)
26+
* [Long-read-based human genomic structural variation detection with cuteSV](https://genomebiology.biomedcentral.com/articles/10.1186/s13059-020-02107-y)
27+
* [An international virtual hackathon to build tools for the analysis of structural variants within species ranging from coronaviruses to vertebrates](https://f1000research.com/articles/10-246)
28+
* [Paragraph: a graph-based structural variant genotyper for short-read sequence data](https://link.springer.com/article/10.1186/s13059-019-1909-7)
29+
* [Genome-wide investigation identifies a rare copy-number variant burden associated with human spina bifida](https://www.nature.com/articles/s41436-021-01126-9)
30+
* [TT-Mars: Structural Variants Assessment Based on Haplotype-resolved Assemblies](https://www.biorxiv.org/content/10.1101/2021.09.27.462044v1.abstract)
31+
* [An ensemble deep learning framework to refine large deletions in linked-reads](https://www.biorxiv.org/content/10.1101/2021.09.27.462057v1.abstract)
+67
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
1+
A frequent application of comparing SVs is to perform a 'bakeoff' of performance
2+
between two SV programs against a single set of base calls.
3+
4+
Beyond looking at the Truvari results/report, you may like to investigate what calls
5+
are different between the programs.
6+
7+
Below is a set of scripts that may help you generate those results. For our examples,
8+
we'll be comparing arbitrary programs Asvs and Bsvs aginst base calls Gsvs.
9+
10+
*_Note_* - This assumes that each record in Gsvs has a unique ID in the vcf.
11+
12+
Generate the Truvari report for Asvs and Bsvs
13+
=============================================
14+
15+
```bash
16+
truvari bench -b Gsvs.vcf.gz -c Asvs.vcf.gz -o cmp_A/ ...
17+
truvari bench -b Gsvs.vcf.gz -c Bsvs.vcf.gz -o cmp_B/ ...
18+
```
19+
Consistency
20+
===========
21+
The simplest way to compare the programs is to get the intersection of TPbase calls from the two reports.
22+
```bash
23+
truvari consistency cmp_A/tp-base.vcf cmp_B/tp-base.vcf
24+
```
25+
See [consistency wiki](../consistency) for details on the report created.
26+
27+
Below are older notes to manually create a similar report to what one can make using `truvari consistency`
28+
29+
Combine the TPs within each report
30+
==================================
31+
32+
```bash
33+
cd cmp_A/
34+
paste <(grep -v "#" tp-base.vcf) <(grep -v "#" tp-call.vcf) > combined_tps.txt
35+
cd ../cmp_B/
36+
paste <(grep -v "#" tp-base.vcf) <(grep -v "#" tp-call.vcf) > combined_tps.txt
37+
```
38+
39+
Grab the FNs missed by only one program
40+
=======================================
41+
42+
```bash
43+
(grep -v "#" cmp_A/fn.vcf && grep -v "#" cmp_B/fn.vcf) | cut -f3 | sort | uniq -c | grep "^ *1 " | cut -f2- -d1 > missed_names.txt
44+
```
45+
46+
Pull the TP sets' difference
47+
============================
48+
49+
```bash
50+
cat missed_names.txt | xargs -I {} grep -w {} cmp_A/combined_tps.txt > missed_by_B.txt
51+
cat missed_names.txt | xargs -I {} grep -w {} cmp_B/combined_tps.txt > missed_by_A.txt
52+
```
53+
54+
To look at the base-calls that Bsvs found, but Asvs didn't, run `cut -f1-12 missed_by_A.txt`.
55+
56+
To look at the Asvs that Bsvs didn't find, run `cut -f13- missed_by_B.txt`.
57+
58+
Shared FPs between the programs
59+
===============================
60+
61+
All of the work above has been about how to analyze the TruePositives. If you'd like to see which calls are shared between Asvs and Bsvs that aren't in Gsvs, simply run Truvari again.
62+
63+
```bash
64+
bgzip cmp_A/fp.vcf && tabix -p vcf cmp_A/fp.vcf.gz
65+
bgzip cmp_B/fp.vcf && tabix -p vcf cmp_B/fp.vcf.gz
66+
truvari bench -b cmp_A/fp.vcf.gz -c cmp_B/fp.vcf.gz -o shared_fps ...
67+
```

docs/v3.5.0/Development.md

+90
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,90 @@
1+
# Truvari API
2+
Many of the helper methods/objects are documented such that developers can reuse truvari in their own code. To see developer documentation, visit [readthedocs](https://truvari.readthedocs.io/en/latest/).
3+
4+
Documentation can also be seen using
5+
```python
6+
import truvari
7+
help(truvari)
8+
```
9+
10+
# docker
11+
12+
A Dockerfile exists to build an image of Truvari. To make a Docker image, clone the repository and run
13+
```bash
14+
docker build -t truvari .
15+
```
16+
17+
You can then run Truvari through docker using
18+
```bash
19+
docker run -v `pwd`:/data -it truvari
20+
```
21+
Where `pwd` can be whatever directory you'd like to mount in the docker to the path `/data/`, which is the working directory for the Truvari run. You can provide parameters directly to the entry point.
22+
```bash
23+
docker run -v `pwd`:/data -it truvari anno svinfo -i example.vcf.gz
24+
```
25+
26+
If you'd like to interact within the docker container for things like running the CI/CD scripts
27+
```bash
28+
docker run -v `pwd`:/data --entrypoint /bin/bash -it truvari
29+
```
30+
You'll now be inside the container and can run FuncTests or run Truvari directly
31+
```bash
32+
bash repo_utils/truvari_ssshtests.sh
33+
truvari anno svinfo -i example.vcf.gz
34+
```
35+
36+
# CI/CD
37+
38+
Scripts that help ensure the tool's quality. Extra dependencies need to be installed in order to run Truvari's CI/CD scripts.
39+
40+
```bash
41+
pip install pylint anybadge coverage
42+
```
43+
44+
Check code formatting with
45+
```bash
46+
python repo_utils/pylint_maker.py
47+
```
48+
We use [autopep8](https://pypi.org/project/autopep8/) (via [vim-autopep8](https://github.com/tell-k/vim-autopep8)) for formatting.
49+
50+
Test the code and generate a coverage report with
51+
```bash
52+
bash repo_utils/truvari_ssshtests.sh
53+
```
54+
55+
Truvari leverages github actions to perform these checks when new code is pushed to the repository. We've noticed that the actions sometimes hangs through no fault of the code. If this happens, cancel and resubmit the job. Once FuncTests are successful, it uploads an artifact of the `coverage html` report which you can download to see a line-by-line accounting of test coverage.
56+
57+
# git flow
58+
59+
To organize the commits for the repository, we use [git-flow](https://danielkummer.github.io/git-flow-cheatsheet/). Therefore, `develop` is the default branch, the latest tagged release is on `master`, and new, in-development features are within `feature/<name>`
60+
61+
When contributing to the code, be sure you're working off of develop and have run `git flow init`.
62+
63+
# versioning
64+
65+
Truvari uses [Semantic Versioning](https://semver.org/). As of v3.0.0, a single version is kept in the code under `truvari/__init__.__version__`. We try to keep the suffix `-dev` on the version in the develop branch. When cutting a new release, we may replace the suffix with `-rc` if we've built a release candidate that may need more testing/development. Once we've committed to a full release that will be pushed to PyPi, no suffix is placed on the version.
66+
67+
# docs
68+
69+
The github wiki serves the documentation most relevant to the `develop/` branch. When cutting a new release, we freeze and version the wiki's documentation with the helper utility `docs/freeze_wiki.sh`.
70+
71+
# Creating a release
72+
Follow these steps to create a release
73+
74+
0) Bump release version
75+
1) Run tests locally
76+
2) Update API Docs
77+
3) Freeze the Wiki
78+
4) Ensure all code is checked in
79+
5) Do a [git-flow release](https://danielkummer.github.io/git-flow-cheatsheet/)
80+
6) Use github action to make a testpypi release
81+
7) Check test release
82+
```bash
83+
python3 -m venv test_truvari
84+
python3 -m pip install --index-url https://test.pypi.org/simple --extra-index-url https://pypi.org/simple/ truvari
85+
```
86+
8) Use GitHub action to make a pypi release
87+
9) Change Updates Wiki
88+
10) Download release-tarball.zip from step #8’s action
89+
11) Create release (include #9) from the tag
90+
12) Checkout develop and Bump to dev version and README ‘commits since’ badge
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
By default, Truvari uses [edlib](https://github.com/Martinsos/edlib) to calculate the edit distance between two SV calls. Optionally, the [Levenshtein edit distance ratio](https://en.wikipedia.org/wiki/Levenshtein_distance) can be used to compute the `--pctsim` between two variants. These measures are different than the sequence similarity calculated by [Smith-Waterman alignment](https://en.wikipedia.org/wiki/Smith%E2%80%93Waterman_algorithm).
2+
3+
To show this difference, consider the following two sequences.:
4+
5+
```
6+
AGATACAGGAGTACGAACAGTACAGTACGA
7+
|||||||||||||||*||||||||||||||
8+
ATCACAGATACAGGAGTACGTACAGTACAGTACGA
9+
10+
30bp Aligned
11+
1bp Mismatched (96% similarity)
12+
5bp Left-Trimmed (~14% of the bottom sequence)
13+
```
14+
15+
The code below runs swalign, Levenshtein, and edlib to compute the `--pctsim` between the two sequences.
16+
17+
18+
```python
19+
import swalign
20+
import Levenshtein
21+
import edlib
22+
23+
seq1 = "AGATACAGGAGTACGAACAGTACAGTACGA"
24+
seq2 = "ATCACAGATACAGGAGTACGTACAGTACAGTACGA"
25+
26+
scoring = swalign.NucleotideScoringMatrix(2, -1)
27+
alner = swalign.LocalAlignment(scoring, gap_penalty=-2, gap_extension_decay=0.5)
28+
aln = alner.align(seq1, seq2)
29+
mat_tot = aln.matches
30+
mis_tot = aln.mismatches
31+
denom = float(mis_tot + mat_tot)
32+
if denom == 0:
33+
ident = 0
34+
else:
35+
ident = mat_tot / denom
36+
scr = edlib.align(seq1, seq2)
37+
totlen = len(seq1) + len(seq2)
38+
39+
print('swalign', ident)
40+
# swalign 0.966666666667
41+
print('levedit', Levenshtein.ratio(seq1, seq2))
42+
# levedit 0.892307692308
43+
print('edlib', (totlen - scr["editDistance"]) / totlen)
44+
# edlib 0.9076923076923077
45+
```
46+
47+
Because the swalign procedure only considers the number of matches and mismatches, the `--pctsim` is higher than the edlib and Levenshtein ratio.
48+
49+
If we were to account for the 5 'trimmed' bases from the Smith-Waterman alignment when calculating the `--pctsim` by counting each trimmed base as a mismatch, we would see the similarity drop to ~83%.
50+
51+
[This post](https://stackoverflow.com/questions/14260126/how-python-levenshtein-ratio-is-computed) has a nice response describing exactly how the Levenshtein ratio is computed.
52+
53+
The Smith-Waterman alignment is much more expensive to compute compared to the Levenshtein ratio, and does not account for 'trimmed' sequence difference.
54+
55+
However, edlib is the fastest comparison method and is used by default. Levenshtein can be specified with `--use-lev` in `bench` and `collapse`.
+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
As part of the GIAB analysis, tandem repeat (TR) stratifications for false positives (FP), false negatives (FN), and true positives (TP) were analyzed. See [this discussion](https://groups.google.com/d/msg/giab-analysis-team/tAtVBm9Fdrw/I2qeazh8AwAJ) for details.
2+
3+
The stratifications.sh script automates the procedure above by taking a Truvari bench output directory as the first argument and TR repeat annotations (found in the link above) to create the following files in the output directory.
4+
5+
Running this script requires `bedtools`, `vcf-sort`, and `bgzip` to be in your environment.
6+
7+
8+
| FileName | Description |
9+
|---------------------|---------------------------------------|
10+
| fn_ins_nonTR.vcf.gz | FN insertions not found in TR regions |
11+
| fn_ins_TR.vcf.gz | FN insertions found in TR regions |
12+
| fp_ins_nonTR.vcf.gz | FP insertions not found in TR regions |
13+
| fp_ins_TR.vcf.gz | FP insertions found in TR regions |
14+
| fn_del_nonTR.vcf.gz | FN insertions not found in TR regions |
15+
| fn_del_TR.vcf.gz | FN insertions found in TR regions |
16+
| fp_del_nonTR.vcf.gz | FP insertions not found in TR regions |
17+
| fp_del_TR.vcf.gz | FP insertions found in TR regions |

docs/v3.5.0/Home.md

+35
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
The wiki holds documentation most relevant for develop. For information on a specific version of Truvari, see [`docs/`](https://github.com/spiralgenetics/truvari/tree/develop/docs)
2+
3+
Truvari: Refined Structural Variant Comparison Preserves Allelic Diversity
4+
doi: https://doi.org/10.1101/2022.02.21.481353
5+
6+
# Before you start
7+
VCFs aren't always created with a strong adherence to the format's specification.
8+
9+
Truvari expects input VCFs to be valid so that it will only output valid VCFs.
10+
11+
We've developed a separate tool that runs multiple validation programs and standard VCF parsing libraries in order to validate a VCF.
12+
13+
Run [this program](https://github.com/acenglish/usable_vcf) over any VCFs that are giving Truvari trouble.
14+
15+
Furthermore, Truvari expects 'resolved' SVs (e.g. DEL/INS) and will not interpret BND signals across SVTYPEs (e.g. combining two BND lines to match a DEL call). A brief description of Truvari bench methodology is linked below.
16+
17+
# Index
18+
19+
- [[Updates|Updates]]
20+
- [[Installation|Installation]]
21+
- Truvari Commands:
22+
- [[bench|bench]]
23+
- [[The multimatch parameter|The--multimatch-parameter]]
24+
- [[Edit Distance Ratio vs Sequence Similarity|Edit-Distance-Ratio-vs-Sequence-Similarity]]
25+
- [[Multi-allelic VCFs|Multi-allelic-VCFs]]
26+
- [[stratifications.sh|GIAB-stratifications.sh]]
27+
- [[Comparing two SV programs|Comparing-two-SV-programs]]
28+
- [[consistency|consistency]]
29+
- [[anno|anno]]
30+
- [[collapse|collapse]]
31+
- [[vcf2df|vcf2df]]
32+
- [[segment|segment]]
33+
- [[Development|Development]]
34+
- [[Citations|Citations]]
35+
- [[Resources|Resources]]

0 commit comments

Comments
 (0)