Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Favourites feature #2

Open
Samridh29 opened this issue Oct 2, 2021 · 7 comments
Open

Add: Favourites feature #2

Samridh29 opened this issue Oct 2, 2021 · 7 comments

Comments

@Samridh29
Copy link
Collaborator

Implement this feature in CategoryViewController and LinksViewController

@kiennguyenchi
Copy link

Hi there, I'm interested in this project and this issue. Could you please assign me to this issue? Thank you!

@Samridh29
Copy link
Collaborator Author

@kiennguyenchi thanks for showing interest in contributing to this repository. Sure, you can work on this issue.
Assigned

@kiennguyenchi
Copy link

Where you want to put the icon of favourites? Because it seems to be no spaces at the top bar.

@Samridh29
Copy link
Collaborator Author

Add bookmark button to each cell in the table view and make the favorites appear at the top everytime the view loads up

kiennguyenchi pushed a commit to kiennguyenchi/sticky-links that referenced this issue Oct 21, 2021
@kevalvadoliya
Copy link
Contributor

Is this issue still open for contribution?

@Samridh29
Copy link
Collaborator Author

Yes. Do you want to work on this issue?

@kevalvadoliya
Copy link
Contributor

Hi @Samridh29, Yes I want to work on this issue.
I have one concern about this issue.
As you said, display favourite items on top but it will break sorting functionality.
I think we can show it as current order and we can add the favourite option to the sorting menu later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants