Skip to content

Possible typo in finetune.py line 305: target_modules should be lora_target_modules ? #79

@Jason-ice-SCUT

Description

@Jason-ice-SCUT

In finetune.py line 305, when initializing LoraConfig, the parameter target_modules is set to target_modules, but it should likely be lora_target_modules (a typo).

Current code:

config = LoraConfig(
    # ... other params ...
    target_modules=target_modules,  # Possible typo here
)

Suggested fix:

config = LoraConfig(
    # ... other params ...
    target_modules=lora_target_modules,  # Use LoRA-specific target modules
)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions