Skip to content

Make maxtext_xpk_runner support other trainers #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lukebaumann opened this issue Apr 9, 2025 · 0 comments
Open

Make maxtext_xpk_runner support other trainers #1552

lukebaumann opened this issue Apr 9, 2025 · 0 comments
Assignees
@suexu1025 @Obliviour
Labels
feature request

Comments

@lukebaumann
Copy link
Collaborator

At the moment, the command is hard coded to execute the MaxText.train module. If the module to execute could be configured in the WorkloadConfig, that would allow for additional trainers being developed to make use of the benchmark runner.

I am running into this while wanting to test a new trainer MaxText.elastic_train in PR #1310 but there are also other trainers being developed and merged and I think configuring maxtext_xpk_runner will be useful moving forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suexu1025 suexu1025

@Obliviour Obliviour

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukebaumann @suexu1025 @Obliviour