Skip to content

Launcher fails to build APKs for mods based on old versions #101

@rm-steele

Description

@rm-steele

Describe the bug
Building an APK for a mod using a version of AM2R that predates the introduction of the /mods/ folder (e.g. 1.1) causes the launcher to error while building due to not being able to find the path %localappdata%/Temp/AM2RLauncherAPKTemp/AM2RWrapper/assets/mods. After the error, the launcher gets stuck in an inoperable state where it seems to not know the build failed (only allowing you to update the mod you already have selected), meaning you need to restart it.

Expected behavior
The launcher would either properly build the APK, or give a user-facing error and gracefully abort the build, allowing the launcher to be used.

To Reproduce
Steps to reproduce the behavior:

  1. Download a mod from this release page. TAM2R is based off of 1.1, Diffusion is based on 1.5.5, included as a control.
  2. Install the mod with the launcher
  3. Attempt to build an APK

Screenshots
Image

Platform

  • OS: Windows 10 Home v2009
  • AM2RLauncher Version: 2.3.0

Additional context
The APK was built using Glenn v1.4, though at Miepee's direction due to Android builds not working for me, I replaced the included version of apktool with this version.

Log file
Log from adding the 1.1 mod, installing it, attempting to build the APK, then closing the launcher after dismissing the error message: AM2RLauncher.log
Log from adding the 1.5.5 mod, installing it, attempting to build the APK, then closing the launcher after it highlights the APK in Explorer: AM2RLauncher.log

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions