Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable-commits are not stable #194

Open
dreemkiller opened this issue Oct 17, 2023 · 2 comments
Open

stable-commits are not stable #194

dreemkiller opened this issue Oct 17, 2023 · 2 comments

Comments

@dreemkiller
Copy link

This repo works with a number of other repos (https://github.com/AMDESE/qemu/, https://github.com/AMDESE/linux, https://github.com/AMDESE/sev-guest) in order to complete a build.

You seem to have set up a system using the stable-commits file to mark the commits to use for a consistent build. However, those stable-commits are not commits, but branches, and those branches are changing. This is creating considerable problems for me when attempting to duplicate my work in any consistent fashion.

As an example of some of the problems I'm seeing, the sev-guest repo currently seems to be out of date in respect to snp-latest on https://github.com/AMDESE/linux, meaning that I cannot build it against that branch (I have to use a specific commit from the branch).

Additionally, even if I were to "set a flag in the ground" and modify the build scripts to use a specific commit (which I have been trying to do), some of the repos (apparently https://github.com/AMDESE/qemu/ at least) seem to be rebasing and pushing with --force, erasing the history that I'm relying on.

Am I doing something wrong? Is there a technique that your team uses to solve these problems that I am missing?

@dreemkiller
Copy link
Author

One thing I left out: I am working on SEV-SNP, so I am referring to how to use the snp-latest branch effectively.

@mdroth
Copy link
Collaborator

mdroth commented Oct 18, 2023

For snp-latest build scripts, there was a recent addition to log the stable-commits and git hashes that were used to build a particular package. They are located in the top-level of the tarball:

~/AMDSEV/snp-release-2023-10-15$ ls source-*
source-commit.kernel.guest source-commit.kernel.host source-commit.ovmf source-commit.qemu source-config

In general, providing a simple way to build the latest dev branches, test, and report failures back through this repo's issue tracker is the main intended flow. If you're want more control over what branches/commits a particular build should correspond to, then you should create a local clone of the repositories in stable-commits, and modify stable-commits to point to those repos / branches instead. This is what we do internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants