Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sources should not need old state information #2503

Open
maxpkatz opened this issue Jun 17, 2023 · 0 comments
Open

New sources should not need old state information #2503

maxpkatz opened this issue Jun 17, 2023 · 0 comments
Assignees
Labels

Comments

@maxpkatz
Copy link
Member

The new-time (corrector) sources use Sborder to compute (1/2) source_old to subtract. But we already store source_old in a MultiFab that is in scope at the time we call do_new_sources(), so we ought to be able to use that MultiFab directly to compute the old-time part of the corrector. Reducing reliance on Sborder in this way may help toward reducing the memory footprint of #276.

@maxpkatz maxpkatz self-assigned this Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant