Skip to content

delete_exe option not working properly #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenWibking opened this issue Feb 12, 2025 · 1 comment
Open

delete_exe option not working properly #152

BenWibking opened this issue Feb 12, 2025 · 1 comment

Comments

@BenWibking
Copy link
Contributor

BenWibking commented Feb 12, 2025

Running in production, the --delete_exe option does not work as expected:

   Sedov-GPU PASSED
   removing subdirectories from test directory...
   removing compressed plotfiles from test directory...
   removing executable from test directory...
Traceback (most recent call last):
  File "/tmp/bwibking/_work/2/s/./extern/regression_testing/regtest.py", line 1354, in <module>
    n = test_suite(sys.argv[1:])
  File "/tmp/bwibking/_work/2/s/./extern/regression_testing/regtest.py", line 1251, in test_suite
    os.remove(executable)
FileNotFoundError: [Errno 2] No such file or directory: 'Sedov-GPU.ex'

Somehow I caused this problem, but it's not immediately obvious how to fix it...

Directory structure:

bwibking@avatargpu:~/regression-tests/quokka-tests/2025-02-12/Sedov-GPU> ls
blast_unigrid_128_regression.in  Sedov-GPU.make.out                    Sedov-GPU_plt10978.gasDensity.YZ.ppm
Sedov-GPU.compare.out            Sedov-GPU_plt10978.gasDensity.XY.png  Sedov-GPU.run.out
Sedov-GPU.err.out                Sedov-GPU_plt10978.gasDensity.XY.ppm
Sedov-GPU.ex                     Sedov-GPU_plt10978.gasDensity.XZ.ppm

Also, the pass to remove the executable from the test directory only runs after the last test is run, rather than after each test, which is odd.

@BenWibking
Copy link
Contributor Author

Feel free to assign me to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant