Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length Restrictions on Input Parameters #359

Open
Aarush-Acharya opened this issue Oct 8, 2024 · 12 comments
Open

Length Restrictions on Input Parameters #359

Aarush-Acharya opened this issue Oct 8, 2024 · 12 comments
Assignees
Labels

Comments

@Aarush-Acharya
Copy link
Contributor

🚀 The feature

Add length restrictions to input parameters, the limit should be such that after exceeding the limit the UI starts to overflow/fall-apart.

Motivation, pitch

It is important to make sure we take care of every possible case as if someone wishing to break the app. All it needs is a really long Title or Description of a Room/Upcoming Room or Story/Chapter that would make the app UI overflow and break it

@M4dhav
Copy link

M4dhav commented Oct 8, 2024

Hey I would like to work on this, please elaborate

@Aarush-Acharya
Copy link
Contributor Author

Hey @M4dhav, make sure to test the UI thoroughly to identify breaking points in order to decide whats best for the project

@Aarush-Acharya
Copy link
Contributor Author

Hey I have merged a PR please pull before working further and make sure to work on the dev branch

@Aarush-Acharya
Copy link
Contributor Author

Hey new PR merged please pull before moving forward

@kanavsharma23
Copy link

Hey, i would also love to work on it

@kartik1112
Copy link

@Aarush-Acharya is it done? or i can work on this?

@M4dhav
Copy link

M4dhav commented Oct 22, 2024

@kartik1112, @kanavsharma23 I am still working on it

@vanshambansal
Copy link

hey would love to work on it

@M4dhav
Copy link

M4dhav commented Oct 25, 2024

@vanshambansal i am working on it

@Aarush-Acharya
Copy link
Contributor Author

Hey @M4dhav any updates on it ??

@M4dhav
Copy link

M4dhav commented Nov 9, 2024

Yes, I have been going through the app thoroughly and have already found and applied length restrictions to a couple of places. Some of them weren't necessary for proper display in the UI, but instead necessary for the backend as the architecture is structured to allow, for example, strings of limited length in places.

Should be done with the entire thing soon

@Aarush-Acharya
Copy link
Contributor Author

Great @M4dhav, keep it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants