[FIX] Fix sale_automatic_workflow_payment_mode migration

Parts of `sale_automatic_workflow_payment_mode` have been merged into `sale_automatic_workflow`.
But these parts have been not removed from `sale_automatic_workflow_payment_mode`.

This PR clean both modules after this merge.

Originals PR of the merge: OCA#1789

(forwrd port of c8d59ed)

Author: jcoux

sale_automatic_workflow/data/automatic_workflow_data.xml

@@ -42,6 +42,14 @@
         >[('state', '=', 'sale'),('invoice_status','=','invoiced')]</field>
         <field name="user_id" ref="base.user_root" />
     </record>
+    <record id="automatic_workflow_payment_filter" model="ir.filters">
+        <field name="name">Automatic Workflow Payment Filter</field>
+        <field name="model_id">account.move</field>
+        <field
+            name="domain"
+        >[('state', '=', 'posted'), ('move_type', '=', 'out_invoice'), ('payment_state','!=','paid')]</field>
+        <field name="user_id" ref="base.user_root" />
+    </record>
     <record id="automatic_validation" model="sale.workflow.process">
         <field name="name">Automatic</field>
         <field name="picking_policy">one</field>
@@ -63,6 +71,8 @@
         <field name="picking_filter_id" eval="automatic_workflow_picking_filter" />
         <field name="sale_done" eval="0" />
         <field name="sale_done_filter_id" eval="automatic_workflow_sale_done_filter" />
+        <field name="register_payment" eval="0" />
+        <field name="payment_filter_id" ref="automatic_workflow_payment_filter" />
         <field
             name="warning"
         >Be careful, if you save the order with this setting, it could be auto-confirmed, even if you are editing it.</field>
@@ -85,6 +95,8 @@
         />
         <field name="picking_filter_id" eval="automatic_workflow_picking_filter" />
         <field name="sale_done_filter_id" eval="automatic_workflow_sale_done_filter" />
+        <field name="register_payment" eval="0" />
+        <field name="payment_filter_id" ref="automatic_workflow_payment_filter" />
     </record>
     <record forcecreate="True" id="ir_cron_automatic_workflow_job" model="ir.cron">
         <field name="name">Automatic Workflow Job</field>

sale_automatic_workflow/models/automatic_workflow_job.py

@@ -174,26 +174,26 @@ def _register_payments(self, payment_filter):
         invoices = invoice_obj.search(payment_filter)
         _logger.debug("Invoices to Register Payment: %s", invoices.ids)
         for invoice in invoices:
-            self._register_payment_invoice(invoice)
+            with savepoint(self.env.cr):
+                self._register_payment_invoice(invoice)
         return
 
     def _register_payment_invoice(self, invoice):
-        with savepoint(self.env.cr):
-            payment = self.env["account.payment"].create(
-                self._prepare_dict_account_payment(invoice)
-            )
-            payment.action_post()
-
-            domain = [
-                ("account_internal_type", "in", ("receivable", "payable")),
-                ("reconciled", "=", False),
-            ]
-            payment_lines = payment.line_ids.filtered_domain(domain)
-            lines = invoice.line_ids
-            for account in payment_lines.account_id:
-                (payment_lines + lines).filtered_domain(
-                    [("account_id", "=", account.id), ("reconciled", "=", False)]
-                ).reconcile()
+        payment = self.env["account.payment"].create(
+            self._prepare_dict_account_payment(invoice)
+        )
+        payment.action_post()
+
+        domain = [
+            ("account_internal_type", "in", ("receivable", "payable")),
+            ("reconciled", "=", False),
+        ]
+        payment_lines = payment.line_ids.filtered_domain(domain)
+        lines = invoice.line_ids
+        for account in payment_lines.account_id:
+            (payment_lines + lines).filtered_domain(
+                [("account_id", "=", account.id), ("reconciled", "=", False)]
+            ).reconcile()
 
     @api.model
     def run_with_workflow(self, sale_workflow):

sale_automatic_workflow/models/sale_workflow_process.py

@@ -27,10 +27,6 @@ def _default_filter(self, xmlid):
             return record
         return self.env["ir.filters"].browse()
 
-    @api.model
-    def _default_payment_filter_id(self):
-        return self.env["ir.filters"].browse()
-
     name = fields.Char()
     picking_policy = fields.Selection(
         selection=[
@@ -126,7 +122,9 @@ def _default_payment_filter_id(self):
     payment_filter_id = fields.Many2one(
         comodel_name="ir.filters",
         string="Register Payment Invoice Filter",
-        default=lambda x: x._default_payment_filter_id(),
+        default=lambda self: self._default_filter(
+            "sale_automatic_workflow.automatic_workflow_payment_filter"
+        ),
     )
     register_payment = fields.Boolean()
     payment_filter_domain = fields.Text(