feat: panic if shelex regex is malformed

Jonathan Watson · Jonathan Watson · commit 76320b6d1b7c · 2025-10-16T14:48:41.000+01:00
Change-Id: Iec341e19b2cd077ed3918bc309209d0f1425e3a0
diff --git a/core/template.go b/core/template.go
@@ -75,7 +75,7 @@ func applyTemplateString(elem reflect.Value, stringvalues map[string]string, fun
 func shlexExpand(field reflect.Value, stringvalues map[string]string) {
 	// matches a value in the format of {{shlex .<value>}}
 	pattern := "^\\{\\{\\s*shlex\\s+\\.(\\w+)\\s*\\}\\}$"
-	regexpr, _ := regexp.Compile(pattern)
+	regexpr := regexp.MustCompile(pattern)
 	if field.Len() < 1 {
 		return
 	}

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ func applyTemplateString(elem reflect.Value, stringvalues map[string]string, fun`
`75`	`75`	`func shlexExpand(field reflect.Value, stringvalues map[string]string) {`
`76`	`76`	`// matches a value in the format of {{shlex .<value>}}`
`77`	`77`	`pattern := "^\\{\\{\\sshlex\\s+\\.(\\w+)\\s\\}\\}$"`
`78`		`- regexpr, _ := regexp.Compile(pattern)`
	`78`	`+ regexpr := regexp.MustCompile(pattern)`
`79`	`79`	`if field.Len() < 1 {`
`80`	`80`	`return`
`81`	`81`	`}`