Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typedef []map[string]string to Rows #43

Open
obelisk opened this issue Oct 7, 2019 · 2 comments
Open

Typedef []map[string]string to Rows #43

obelisk opened this issue Oct 7, 2019 · 2 comments
Labels
debt

Comments

@obelisk
Copy link
Collaborator

obelisk commented Oct 7, 2019

That's what it is and will make prototypes much simpler
@obelisk obelisk added debt good first issue Good for newcomers labels Oct 18, 2019
@obelisk
Copy link
Collaborator Author

obelisk commented Oct 19, 2019

@AbGuthrie Where should these types live? We should have one for Row and Rows (being []Row) at least.

@AbGuthrie
Copy link
Owner

Maybe we can consider an info/types/model module.

For now the Rows typedef in printer.go in utils is valid and importable by any other module that needs to pass rows to the printer.

@obelisk obelisk removed the good first issue Good for newcomers label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obelisk @AbGuthrie