Skip to content

Commit 71d1bee

Browse files
committed
CodeRabbit review comments implementation.
1 parent c939254 commit 71d1bee

File tree

4 files changed

+16
-17
lines changed

4 files changed

+16
-17
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @ABMC831 @Zejnilovic @oto-macenauer-absa @petr-pokorny-absa @tmikula-dev
1+
* @oto-macenauer-absa @petr-pokorny-absa @tmikula-dev @lsulak

requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,3 @@ boto3==1.40.25
1414
confluent-kafka==2.12.1
1515
# psycopg2-binary==2.9.10 # Ideal for local development, but not for long-term production use
1616
psycopg2==2.9.10
17-
botocore==1.42.4

src/event_gate_lambda.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,12 @@ def get_api() -> Dict[str, Any]:
9191
return {"statusCode": 200, "body": API}
9292

9393

94-
def lambda_handler(event: Dict[str, Any]) -> Dict[str, Any]:
94+
def lambda_handler(event: Dict[str, Any], context: Any = None) -> Dict[str, Any]:
9595
"""
9696
AWS Lambda entry point. Dispatches based on API Gateway proxy 'resource' and 'httpMethod'.
9797
Args:
9898
event: The event data from API Gateway.
99+
context: The mandatory context argument for AWS Lambda invocation.
99100
Returns:
100101
A dictionary compatible with API Gateway Lambda Proxy integration.
101102
Raises:

tests/handlers/test_handler_topic.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424

2525
## load_topic_schemas()
2626
def test_load_topic_schemas_success():
27-
"""Test successful loading of all topic schemas."""
2827
mock_handler_token = MagicMock()
2928
access_config = {"public.cps.za.test": ["TestUser"]}
3029
handler = HandlerTopic("conf", access_config, mock_handler_token)
@@ -138,9 +137,9 @@ def test_post_invalid_token_decode(event_gate_module, make_event, valid_payload)
138137
def test_post_success_all_writers(event_gate_module, make_event, valid_payload):
139138
with (
140139
patch.object(event_gate_module.handler_token, "decode_jwt", return_value={"sub": "TestUser"}),
141-
patch("src.event_gate_lambda.writer_kafka.write", return_value=(True, None)),
142-
patch("src.event_gate_lambda.writer_eventbridge.write", return_value=(True, None)),
143-
patch("src.event_gate_lambda.writer_postgres.write", return_value=(True, None)),
140+
patch("src.handlers.handler_topic.writer_kafka.write", return_value=(True, None)),
141+
patch("src.handlers.handler_topic.writer_eventbridge.write", return_value=(True, None)),
142+
patch("src.handlers.handler_topic.writer_postgres.write", return_value=(True, None)),
144143
):
145144
event = make_event(
146145
"/topics/{topic_name}",
@@ -159,9 +158,9 @@ def test_post_success_all_writers(event_gate_module, make_event, valid_payload):
159158
def test_post_single_writer_failure(event_gate_module, make_event, valid_payload):
160159
with (
161160
patch.object(event_gate_module.handler_token, "decode_jwt", return_value={"sub": "TestUser"}),
162-
patch("src.event_gate_lambda.writer_kafka.write", return_value=(False, "Kafka boom")),
163-
patch("src.event_gate_lambda.writer_eventbridge.write", return_value=(True, None)),
164-
patch("src.event_gate_lambda.writer_postgres.write", return_value=(True, None)),
161+
patch("src.handlers.handler_topic.writer_kafka.write", return_value=(False, "Kafka boom")),
162+
patch("src.handlers.handler_topic.writer_eventbridge.write", return_value=(True, None)),
163+
patch("src.handlers.handler_topic.writer_postgres.write", return_value=(True, None)),
165164
):
166165
event = make_event(
167166
"/topics/{topic_name}",
@@ -181,9 +180,9 @@ def test_post_single_writer_failure(event_gate_module, make_event, valid_payload
181180
def test_post_multiple_writer_failures(event_gate_module, make_event, valid_payload):
182181
with (
183182
patch.object(event_gate_module.handler_token, "decode_jwt", return_value={"sub": "TestUser"}),
184-
patch("src.event_gate_lambda.writer_kafka.write", return_value=(False, "Kafka A")),
185-
patch("src.event_gate_lambda.writer_eventbridge.write", return_value=(False, "EB B")),
186-
patch("src.event_gate_lambda.writer_postgres.write", return_value=(True, None)),
183+
patch("src.handlers.handler_topic.writer_kafka.write", return_value=(False, "Kafka A")),
184+
patch("src.handlers.handler_topic.writer_eventbridge.write", return_value=(False, "EB B")),
185+
patch("src.handlers.handler_topic.writer_postgres.write", return_value=(True, None)),
187186
):
188187
event = make_event(
189188
"/topics/{topic_name}",
@@ -201,16 +200,16 @@ def test_post_multiple_writer_failures(event_gate_module, make_event, valid_payl
201200
def test_token_extraction_lowercase_bearer_header(event_gate_module, make_event, valid_payload):
202201
with (
203202
patch.object(event_gate_module.handler_token, "decode_jwt", return_value={"sub": "TestUser"}),
204-
patch("src.event_gate_lambda.writer_kafka.write", return_value=(True, None)),
205-
patch("src.event_gate_lambda.writer_eventbridge.write", return_value=(True, None)),
206-
patch("src.event_gate_lambda.writer_postgres.write", return_value=(True, None)),
203+
patch("src.handlers.handler_topic.writer_kafka.write", return_value=(True, None)),
204+
patch("src.handlers.handler_topic.writer_eventbridge.write", return_value=(True, None)),
205+
patch("src.handlers.handler_topic.writer_postgres.write", return_value=(True, None)),
207206
):
208207
event = make_event(
209208
"/topics/{topic_name}",
210209
method="POST",
211210
topic="public.cps.za.test",
212211
body=valid_payload,
213-
headers={"bearer": "token"},
212+
headers={"authorization": "bearer token"},
214213
)
215214
resp = event_gate_module.lambda_handler(event)
216215
assert resp["statusCode"] == 202

0 commit comments

Comments
 (0)