-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNeg’s XStudio on windows with CMake #100
Comments
Try to enable USE_VCPKG, the windows branch has a vcpkg.json file which should make dependency install alot easier. |
Hello here I have a similar experience:
Enabling USE_VCPKG does not help :/ |
Sounds like installing and invoking vcpkg failed, would you be able to share beginning on cmake log? You are on mpkepic/xstudio windows branch? |
I was manually downloading a lot of dependencies using vcpkg now and manually edited all the pathnames, but currently stuck with liblzma which is installed, but cmake is looking for a lzma_auto_decoder which is not part of the installation and also nowhere to be found |
Hi! I've done a significant overhaul on the Cmake/vcpkg integration and cmake install target support among other things. I recommend checking out the latest commit on the pull request. Note it now supports Visual Studio 2022, comes with some useful presets to make configuring easier, and has a bunch of build reliability improvements. |
yes, you posted an update on the next day, and I could finally make it work. It was also crucial to run the power-shell script setting up the environment properly which doesn't work with an unaltered system where running scripts is not allowed. it is now up and running, still get some python related error messages on boot-up and xStudio doesn't recognize EXR sequences as such but instead only loads one image |
Thanks, I'm spinning off that issue into #106; see there for updates. |
Thanks..will look into that today. I have also the issue that loading from my NAS is not supported, but I have seen that this is mentioned somewhere already. Guess it is the double-slash issue if I remember right |
Can you please open a new issue for this with any sort of useful examples? I'm trying (and failing) to prevent these massive monolithic issues that keep morphing :) |
Will do. But currently I wasn't able to build your fork due to VCPKG not being able to create MP3LAME |
can you provide the relevant section from the build logs? alternatively you can use a prebuilt ffmpeg 5.1.2 and set FFMPEG_ROOT |
Also gives the error when using vcpkg install directly and when using "full" vcpkg without manifest using vcpkg install mp3lame. I used the prebuild FFMPEG on my first build, but adding FFMPEG_ROOT set to C:\ffmpeg\bin seems to be ignored |
If using prebuilt, you can remove ffmpeg from the manifest, add the FFMPEG_ROOT and point it to the non-bin directory; make sure your ffmpeg prebuilt is the full shared version (with dll and libs), not just the executable. |
Given the error is failing to find some very core files, validate two things for me:
Alternatively, you can be more discerning about which packages you pull in by modifying the manifest to set the features in ffmpeg and only include specific features. |
yes, set the file path limitation from 0 to 1 and have plenty of drive space on each drive on this machine. So just to make sure, the manifest is vcpkg.json? running vcpkg install ffmpeg builds fine, just MP3LAME is not. but I have seen that by default ffmpeg builds using --disable-libmp3lame. Sorry for all those noob questions, but I am not a developer and just trying to get some of the open source tools running, which is really giving me a hard time |
Yes, vcpkg.json is the manifest.
…On Mon, Jun 10, 2024 at 8:06 AM Volker Troy ***@***.***> wrote:
yes, set the file path limitation from 0 to 1 and have plenty of drive
space on each drive on this machine.
So just to make sure, the manifest is vcpkg.json?
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/AcademySoftwareFoundation/xstudio/issues/100*issuecomment-2158613749__;Iw!!N1d2nkBXpQ!Ivz9i0mrUoKhtPBH7NKnyKR8tm-_cATpC6fByXAti67UfPnd3SEs26Xya_P5tTzL-XZ3YvLDjC7HGiYOxXZ6MfD2lGuUYkU$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AZXQR2SJVRVPAPTSAQ7LDYDZGW6IHAVCNFSM6AAAAABESQDZBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJYGYYTGNZUHE__;!!N1d2nkBXpQ!Ivz9i0mrUoKhtPBH7NKnyKR8tm-_cATpC6fByXAti67UfPnd3SEs26Xya_P5tTzL-XZ3YvLDjC7HGiYOxXZ6MfD2U6QpIeA$>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
What I meant is you can modify the "features": ["all"] to be, instead of "all", a list of features you wish to include, as enumerated here: As far as why mp3lame won't work, 🤷 but given it fails with vcpkg outside of the xstudio build, I suspect it is something to do with your specific computer configuration. |
Hi,
i am trying to install DNeg’s XStudio on windows with CMake, but i am finding many difficulties.
Every time I do the CMake setup it tells me that a new package is missing.
the first one was “nlohmann_json”
(solved by downloading the package from GitHub and placed in the folder
./XStudio/xstudio/build/vcpkg/packages/nlohmann-json_x64-windows/share/nlohmann_json)
the second one “pybind11”
(solved by downloading the package via Python and placed in the folder
C:/Users/User/AppData/Local/Packages/PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0/LocalCache/local-packages/Python312/site-packages/pybind11/share/cmake/pybind11
now it is “cafConfig.cmake” which i can’t figure out where to find it.
I wanted to know if there was a single guide on how to implement XStudio, because online I can’t find a comprehensive guide on the various procedures to follow.
the only generic guide is on
mpkepic/xstudio/blob/windows/docs/build_guides/windows.md
but it is missing all the contingencies that I am finding.
Thanks in advance
Giuseppe
The text was updated successfully, but these errors were encountered: