PlaidException should be type of System.Exception

[derekantrican]

PlaidException should inherit from System.Exception so that something like throw getTransactionsResponse.Exception; is a valid use. If not, I would argue that the name "Exception" here is changed to something different (like "Error")

[danports]

Was trying to upgrade from an older version of the library today and ran into this. PlaidException used to inherit from System.Exception, but then that was changed in 329c640, so a throw response.Exception statement I had written earlier no longer compiles.

@Ackara Can you please help us understand why this change was made?

[viceroypenguin]

@derekantrican @danports - I'm afraid that's my fault. I modernized the library in my fork (viceroypenguin/Going.Plaid). I removed the Exception base because the object is actually a DTO that Plaid defines, and is a common situation, not an exceptional one. I should have renamed it to PlaidError, but I did not.

I have updated my library to v4.0 to change the name to PlaidError, based on these comments.