WIP: aw-query: Test make variables get consumed

Previously they were cloned on each reference

Author: johan-bjareholt

Makefile

@@ -47,3 +47,10 @@ install:
 	# Install systemd user service
 	mkdir -p $(DESTDIR)$(PREFIX)/lib/systemd/user
 	install -m 644 aw-server.service $(DESTDIR)$(PREFIX)/lib/systemd/user/aw-server.service
+
+coverage:
+	export CARGO_INCREMENTAL=0
+	export RUSTFLAGS="-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort"
+	export RUSTDOCFLAGS="-Cpanic=abort"
+	cargo build --verbose $(cargoflag)
+	cargo test --verbose $(cargoflag)

aw-query/benches/benchmark.rs

@@ -70,7 +70,7 @@ mod query_benchmarks {
         }
         //
         let mut event_list = Vec::new();
-        for i in 0..3000 {
+        for i in 0..30000 {
             let e = Event {
                 id: None,
                 timestamp: chrono::Utc::now() + Duration::seconds(i),

aw-query/src/ast.rs

@@ -24,6 +24,7 @@ pub enum Expr_ {
     Equal(Box<Expr>, Box<Expr>),
 
     Var(String),
+    VarRef(String),
     Assign(String, Box<Expr>),
     Function(String, Box<Expr>),
     If(Vec<(Box<Expr>, Vec<Expr>)>),

aw-query/src/interpret.rs

@@ -182,11 +182,17 @@ fn interpret_expr(
             env.insert(var, val);
             Ok(DataType::None())
         }
-        // FIXME: avoid clone, it's slow
-        Var(var) => match env.get(&var) {
-            Some(v) => Ok(v.clone()),
+        Var(var) => match env.remove(&var) {
+            Some(v) => Ok(v),
             None => Err(QueryError::VariableNotDefined(var.to_string())),
         },
+        VarRef(var) => {
+            // TODO: Remove clone
+            match env.get(&var) {
+                Some(v) => Ok(v.clone()),
+                None => Err(QueryError::VariableNotDefined(var.to_string())),
+            }
+        }
         Bool(lit) => Ok(DataType::Bool(lit)),
         Number(lit) => Ok(DataType::Number(lit)),
         String(litstr) => Ok(DataType::String(litstr.to_string())),

aw-query/src/lexer.rs

@@ -13,6 +13,7 @@ pub enum Token {
     Number(f64),
     String(String),
     Plus,
+    Ampersand,
     Minus,
     Star,
     Slash,
@@ -69,6 +70,7 @@ lexer! {
 
     r#"=="# => (Token::Equals, text),
     r#"="# => (Token::Assign, text),
+    r#"\&"# => (Token::Ampersand, text),
     r#"\+"# => (Token::Plus, text),
     r#"-"# => (Token::Minus, text),
     r#"\*"# => (Token::Star, text),

aw-query/src/parser.rs

@@ -246,6 +246,10 @@ parser! {
             span: span!(),
             node: Expr_::Var(v),
         },
+        Ampersand Ident(v) => Expr {
+            span: span!(),
+            node: Expr_::VarRef(v),
+        },
         Bool(b) => Expr {
             span: span!(),
             node: Expr_::Bool(b),

aw-query/tests/query.rs

@@ -232,7 +232,7 @@ mod query_tests {
         let code = String::from(
             "
             a=True; n=1;
-            if a { n=2; }
+            if &a { n=2; }
             return n;",
         );
         match aw_query::query(&code, &interval, &ds).unwrap() {
@@ -269,8 +269,8 @@ mod query_tests {
         let code = String::from(
             "
             a=False; b=True; n=1;
-            if a { n=2; }
-            elif b { n=3; }
+            if &a { n=2; }
+            elif &b { n=3; }
             return n;",
         );
         match aw_query::query(&code, &interval, &ds).unwrap() {
@@ -282,8 +282,8 @@ mod query_tests {
         let code = String::from(
             "
             a=False; b=True; n=1;
-            if a { n=2; }
-            elif a { n=3; }
+            if &a { n=2; }
+            elif &a { n=3; }
             else { n=4; }
             return n;",
         );
@@ -296,7 +296,7 @@ mod query_tests {
         let code = String::from(
             "
             a=True; n=1;
-            if a { if a { n = 2; } }
+            if &a { if &a { n = 2; } }
             return n;",
         );
         match aw_query::query(&code, &interval, &ds).unwrap() {
@@ -359,16 +359,16 @@ mod query_tests {
             events = concat(events, query_bucket("{}"));
             events = categorize(events, [[["test"], {{ "type": "regex", "regex": "value$" }}], [["test", "testing"], {{ "type": "regex", "regex": "value$" }}]]);
             events = tag(events, [["testtag", {{ "type": "regex", "regex": "test$" }}], ["another testtag", {{ "type": "regex", "regex": "test-pat$" }}]]);
-            total_duration = sum_durations(events);
+            total_duration = sum_durations(&events);
             bucketnames = query_bucket_names();
             print("test", "test2");
-            url_events = split_url_events (events);
-            filtered_events = filter_period_intersect(events, events);
-            filtered_events = filter_keyvals(events, "$category", [["Uncategorized"]]);
-            filtered_events = filter_keyvals_regex(events, "key", "regex");
-            chunked_events = chunk_events_by_key(events, "key");
-            merged_events = merge_events_by_keys(events, ["key"]);
-            return  merged_events;"#,
+            events = split_url_events (events);
+            events = filter_period_intersect(&events, &events);
+            events = filter_keyvals(events, "$category", [["Uncategorized"]]);
+            events = filter_keyvals_regex(events, "key", "regex");
+            events = chunk_events_by_key(events, "key");
+            events = merge_events_by_keys(events, ["key"]);
+            return events;"#,
             "testid", "testid"
         );
         match aw_query::query(&code, &interval, &ds).unwrap() {