Merge pull request #27 from AdamWyatt34/update-dogfood

Enhance GitHub Actions support by handling unexpanded expressions and…

Author: AdamWyatt34

scripts/self-test.ps1

@@ -91,11 +91,19 @@ $StartTime = Get-Date
 $ExitCode = 0
 
 # Run PDK and capture output
+# Use --host mode to run on local machine (where .NET is already installed)
+# Skip steps that use GitHub Actions (setup-dotnet, cache, upload-artifact, codecov)
+# Skip Build step - PDK is already built and running, can't rebuild itself (file locks)
+# Run: checkout, restore, unit tests (validates PDK can execute a real workflow)
 try {
     & dotnet run --project src/PDK.CLI/PDK.CLI.csproj `
         --no-build --configuration Release -- `
         run --file .github/workflows/ci.yml `
         --job build `
+        --host `
+        --step-filter "Checkout code" `
+        --step-filter "Restore dependencies" `
+        --step-filter "Run unit tests" `
         --verbose 2>&1 | Tee-Object -FilePath "$OutputDir/output.log"
     $ExitCode = $LASTEXITCODE
 } catch {

scripts/self-test.sh

@@ -84,18 +84,26 @@ echo ""
 
 # Run PDK on its own workflow
 echo "${CYAN}Running PDK on .github/workflows/ci.yml...${RESET}"
-echo "Command: dotnet run --project src/PDK.CLI/PDK.CLI.csproj --no-build --configuration Release -- run --file .github/workflows/ci.yml --job build --verbose"
+echo "Using --host mode with step filters (skipping GitHub Actions-only steps)"
 echo ""
 echo "========== PDK Output Begin =========="
 
 START_TIME=$(date +%s)
 EXIT_CODE=0
 
 # Run PDK and capture output
+# Use --host mode to run on local machine (where .NET is already installed)
+# Skip steps that use GitHub Actions (setup-dotnet, cache, upload-artifact, codecov)
+# Skip Build step - PDK is already built and running, can't rebuild itself (file locks)
+# Run: checkout, restore, unit tests (validates PDK can execute a real workflow)
 dotnet run --project src/PDK.CLI/PDK.CLI.csproj \
     --no-build --configuration Release -- \
     run --file .github/workflows/ci.yml \
     --job build \
+    --host \
+    --step-filter "Checkout code" \
+    --step-filter "Restore dependencies" \
+    --step-filter "Run unit tests" \
     --verbose 2>&1 | tee "$OUTPUT_DIR/output.log" || EXIT_CODE=$?
 
 END_TIME=$(date +%s)

src/PDK.CLI/PipelineExecutor.cs

@@ -251,6 +251,12 @@ public async Task Execute(ExecutionOptions options)
             if (!result.Success)
             {
                 allJobsSucceeded = false;
+
+                // Display job error message if available
+                if (!string.IsNullOrEmpty(result.ErrorMessage))
+                {
+                    _output.WriteError($"  {result.ErrorMessage}");
+                }
             }
         }
 

src/PDK.Core/Runners/RunnerCapabilities.cs

@@ -115,6 +115,13 @@ public static IReadOnlyList<string> ValidateJobRequirements(Job job, RunnerType
     /// </summary>
     private static bool IsStandardRunner(string runsOn)
     {
+        // Handle unexpanded GitHub Actions expressions (e.g., ${{ matrix.os }})
+        // Assume they resolve to standard runners since matrix typically uses them
+        if (runsOn.Contains("${{") || runsOn.Contains("}}"))
+        {
+            return true;
+        }
+
         // Standard runners that can work on host (local machine equivalents)
         var standardRunners = new HashSet<string>(StringComparer.OrdinalIgnoreCase)
         {

src/PDK.Runners/Docker/ImageMapper.cs

@@ -70,6 +70,13 @@ public string MapRunnerToImage(string runnerName)
             return imageName;
         }
 
+        // Handle unexpanded GitHub Actions expressions (e.g., ${{ matrix.os }})
+        // Default to ubuntu-latest since matrix builds aren't fully supported yet
+        if (runnerName.Contains("${{") || runnerName.Contains("}}"))
+        {
+            return RunnerMappings["ubuntu-latest"];
+        }
+
         // Runner not recognized
         throw new ArgumentException(
             $"Runner '{runnerName}' is not recognized. " +