Skip to content

Commit 149baca

Browse files
committed
fix: code-review fixes
1 parent 1f92232 commit 149baca

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

src/hooks/queries/transaction/useBtcTransactionQuery.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export function useBtcTransactionQuery(
3030
retry: (failureCount: number): boolean => {
3131
// Don't retry dust amount BTC transactions
3232
const dustedIds = store.state.btc.dustedTransactionsIds || []
33-
if (dustedIds.length > 0 && dustedIds.includes(unref(transactionId))) {
33+
if (dustedIds.includes(unref(transactionId))) {
3434
return false
3535
}
3636
return retryFactory(Cryptos.BTC, unref(transactionId))(failureCount)

src/hooks/queries/transaction/useDashTransactionQuery.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export function useDashTransactionQuery(
3030
retry: (failureCount: number): boolean => {
3131
// Don't retry dust amount DASH transactions
3232
const dustedIds = store.state.dash.dustedTransactionsIds || []
33-
if (dustedIds.length > 0 && dustedIds.includes(unref(transactionId))) {
33+
if (dustedIds.includes(unref(transactionId))) {
3434
return false
3535
}
3636
return retryFactory(Cryptos.DASH, unref(transactionId))(failureCount)

src/hooks/queries/transaction/useDogeTransactionQuery.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export function useDogeTransactionQuery(
3030
retry: (failureCount: number): boolean => {
3131
// Don't retry dust amount DOGE transactions
3232
const dustedIds = store.state.doge.dustedTransactionsIds || []
33-
if (dustedIds.length > 0 && dustedIds.includes(unref(transactionId))) {
33+
if (dustedIds.includes(unref(transactionId))) {
3434
return false
3535
}
3636
return retryFactory(Cryptos.DOGE, unref(transactionId))(failureCount)

src/store/modules/btc-base/btc-base-actions.js

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -231,15 +231,11 @@ function createActions(options) {
231231

232232
return hash
233233
} catch (error) {
234-
if (error.response?.data?.includes?.('dust') ||
235-
error.response?.data?.error?.message?.includes?.('dust')) {
236-
context.commit('dustedTransactionsIds', signedTransaction.txid);
237-
}
238-
if (
239-
((crypto === 'BTC' || crypto === 'DOGE') && error.response.data.includes('dust')) ||
240-
(crypto === 'DASH' && error.response.data.error.message.includes('dust'))
241-
)
242-
context.commit('dustedTransactionsIds', signedTransaction.txid)
234+
if (
235+
error.response?.data?.includes('dust') ||
236+
error.response?.data?.error?.message?.includes('dust')
237+
) {
238+
context.commit('dustedTransactionsIds', signedTransaction.txid)
243239
}
244240
context.commit('transactions', [{ hash: signedTransaction.txid, status: 'REJECTED' }])
245241

0 commit comments

Comments
 (0)