Wrong rule is displayed for page blocked by `$document` rule in MV3

[AdamWr]

Please answer the following questions for yourself before submitting an issue

• Filters were updated before reproducing an issue
• I checked the knowledge base and found no answer
• I checked to make sure that this issue has not already been filed

AdGuard Extension version

5.2.25 beta

Browser version

Chrome 138

OS version

Windows 11

Issue Details

Steps to reproduce:

1. Add to user rules:

@@||example.org^$generichide
||example.org^$document

2. Go to - http://example.org/

Expected Behavior

Website is blocked and ||example.org^$document rule is displayed.

Actual Behavior

Website is blocked and @@||example.org^$generichide rule is displayed.

Screenshots

Screenshot 1

Additional Information

By the way, when I click Proceed anyway then website is unblocked and my question is, how long time I have to wait so website will be blocked again, or what I have to do to revert it?

[slavaleleka]

how long time I have to wait so website will be blocked again, or what I have to do to revert it?

wait 40 minutes

AdguardBrowserExtension/Extension/src/background/api/document-block.ts

Lines 26 to 30 in 4bedbb1

	/**
	* For how long will the application exclude the provided domain
	* from blocking by the $document rule.
	*/
	public static readonly TRUSTED_TTL_MS = 40 * 60 * 1000; // 40 min

or Reset Settings (in Additional Settings) and not wait

[SampeiNihira]

40 minutes is too long,consider making a change as is done in uBlock Origin with closing/reopening the browser will reset the permission which is then temporary.

This rule prevents github malware downloading:

||github.com/*/*.exe$document

https://urlhaus.abuse.ch/url/3573710/

But it also prevents the downloading of software 7-zip:

https://www.7-zip.org/

if I click the mouse on the “proceed anyway” button this exception should be temporary and not expose me to download malwares (for 40').

P.S.

It is better to use the extension pause.
In my opinion, few users think that for 40' you granted an exception to the websites you intended to block.

[slavaleleka]

@@||example.org^$generichide
||example.org^$document

Expected Behavior

Website is blocked and ||example.org^$document rule is displayed

$document blocking rule should not be applied in this case since $generichide exception rule has higher priority. I'll change the issue title and description

[AdamWr]

$document blocking rule should not be applied in this case since $generichide exception rule has higher priority.

Are you sure about that?
As far as I know, it should be applied and it works like that in CoreLibs apps (I mean that rule with $document is not disabled by $generichide rule).
For example, there is a rule:

@@||github.com^$generichide

in a Base filter and some filter lists, like Online Malicious URL Blocklist block specific github.com URLs, so all these rules will stop working.

---

Regarding - #3260 (comment)
I agree with that, 40 minutes is too long. If I'm not wrong, in app it's blocked again after few minutes and we can delete cookie to block it earlier, this way it's not necessary to reset all settings.

[slavaleleka]

$document blocking rule should not be applied in this case since $generichide exception rule has higher priority

Are you sure about that?
As far as I know, it should be applied and it works like that in CoreLibs apps (I mean that rule with $document is not disabled by $generichide rule).

Thanks for pointing out the CoreLibs implementation.

Earlier I checked the MV2 extension implementation where $generichide exception rules prevail over $document blocking rules. It seems that this behaviour should be fixed for consistency, I'll file another issue for MV2 later. And the current behaviour in the MV3 extension looks consistent with the CoreLibs apps (correct rule displaying should still be fixed).

Regarding the 40-minute period, it requires further investigation and discussion.

---

UPD1:
Issue for MV2 #3262

UPD2:
Issue for time period decreasing #3263