From ef8a61fdd5178cc1ef78f13d52c1093a48726cc4 Mon Sep 17 00:00:00 2001 From: Artem Ivanov Date: Wed, 2 Oct 2019 12:13:06 +0300 Subject: [PATCH 1/3] Improved rate notification behavior --- .../com/adguard/android/contentblocker/ui/MainActivity.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/adguard_cb/src/main/java/com/adguard/android/contentblocker/ui/MainActivity.java b/adguard_cb/src/main/java/com/adguard/android/contentblocker/ui/MainActivity.java index fc368b5..60d8c40 100644 --- a/adguard_cb/src/main/java/com/adguard/android/contentblocker/ui/MainActivity.java +++ b/adguard_cb/src/main/java/com/adguard/android/contentblocker/ui/MainActivity.java @@ -200,6 +200,9 @@ private void showRateDialog(Intent intent) { return; } + // We show notification MAX_RATE_DIALOG_COUNT times or while user didn't push a notification + preferencesService.setAppRated(true); + int filledCount = intent.getIntExtra(STARS_COUNT, 0); final View dialogLayout = LayoutInflater.from(this).inflate(R.layout.rate_dialog, null); final ViewGroup starsLayout = dialogLayout.findViewById(R.id.stars_layout); @@ -221,8 +224,6 @@ private void showRateDialog(Intent intent) { View.OnClickListener buttonsListener = v -> { if (v.getId() == R.id.button_submit) { - // TODO collect feedback - preferencesService.setAppRated(true); showFeedbackSubmitDialog(); } preferencesService.increaseRateAppDialogCount(); From dc528bc02bc998384fb28e16b4c716692843c6c9 Mon Sep 17 00:00:00 2001 From: Artem Ivanov Date: Wed, 2 Oct 2019 12:17:19 +0300 Subject: [PATCH 2/3] We need collect feedback --- .../java/com/adguard/android/contentblocker/ui/MainActivity.java | 1 + 1 file changed, 1 insertion(+) diff --git a/adguard_cb/src/main/java/com/adguard/android/contentblocker/ui/MainActivity.java b/adguard_cb/src/main/java/com/adguard/android/contentblocker/ui/MainActivity.java index 60d8c40..e7d5376 100644 --- a/adguard_cb/src/main/java/com/adguard/android/contentblocker/ui/MainActivity.java +++ b/adguard_cb/src/main/java/com/adguard/android/contentblocker/ui/MainActivity.java @@ -224,6 +224,7 @@ private void showRateDialog(Intent intent) { View.OnClickListener buttonsListener = v -> { if (v.getId() == R.id.button_submit) { + // TODO collect feedback showFeedbackSubmitDialog(); } preferencesService.increaseRateAppDialogCount(); From 1c5fabfb91932f974086ffb336242e84fb66b707 Mon Sep 17 00:00:00 2001 From: Artem Ivanov Date: Wed, 2 Oct 2019 12:18:24 +0300 Subject: [PATCH 3/3] Bumped version --- adguard_cb/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adguard_cb/build.gradle b/adguard_cb/build.gradle index a58082a..bcef1e3 100644 --- a/adguard_cb/build.gradle +++ b/adguard_cb/build.gradle @@ -18,8 +18,8 @@ android { minSdkVersion 21 targetSdkVersion 28 applicationId 'com.adguard.android.contentblocker' - versionCode 22000003 - versionName '2.5.2' + versionCode 22000004 + versionName '2.5.3' signingConfig signingConfigs.config }