-
Notifications
You must be signed in to change notification settings - Fork 158
Add LKBIN DNS services and descriptions #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added information about LKBIN DNS and its various services, including AdBlock, Unfiltered, Anti Malware, Family DNS, Hagezi Filter, and AdGuard Filter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
Updated the section header from 'Family DNS' to 'FAMILY DNS' and added a description of the Family DNS service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already fix the issue /windsurf-review
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
|
/windsurf-review It doesn't provide anything other than dns over https |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
|
|
||
| Ad-Blocking DNS is a service that automatically blocks advertisements and online trackers. By filtering unwanted domains at the DNS level, it prevents intrusive ads from loading and stops tracking scripts from collecting user data, resulting in a cleaner, faster, and more private browsing experience. | ||
|
|
||
| | Protocol | Address | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR only includes DNS-over-HTTPS endpoints for LKBIN DNS. Do they also offer DNS-over-TLS or plain DNS options? If so, it would be good to include those for consistency with other providers in this document.
| #### ANTI MALWARE | ||
|
|
||
| DNS Anti Malware / DNS Antivirus is a protective DNS service designed to safeguard users against online threats. It automatically blocks access to domains associated with malware, ransomware, and phishing attacks, helping ensure a safer and more secure browsing experience. | ||
|
|
||
| | Protocol | Address | | | ||
| |----------------|----------------------------------------------------|----------------| | ||
| | DNS-over-HTTPS | `https://mydns.lkbin.my.id/antivirus` | [Add to AdGuard](adguard:add_dns_server?address=https://mydns.lkbin.my.id/antivirus&name=mydns.lkbin.my.id), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://mydns.lkbin.my.id/antivirus&name=mydns.lkbin.my.id) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's inconsistency between section headers and the actual endpoint paths. For example, the section is titled 'ANTI MALWARE' but the endpoint is '/antivirus'. Consider aligning these names for clarity.
Say I've fixed that error. /windsurf-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
docs/general/dns-providers.md
Outdated
| #### ADGUARD FILTER | ||
|
|
||
| This DNS service uses AdGuard’s advanced filtering technology to block ads, trackers, and malicious domains directly at the DNS level. By leveraging AdGuard’s regularly updated blocklists, it enhances privacy, improves browsing speed, and protects users from harmful or unwanted online content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section describes a third-party implementation using AdGuard's filtering technology, but doesn't clarify the relationship with the official AdGuard DNS services documented earlier in this file. Consider adding a note to clarify that this is a third-party implementation of AdGuard's filtering technology to avoid confusion for users.
docs/general/dns-providers.md
Outdated
| |----------------|----------------------------------------------------|----------------| | ||
| | DNS-over-HTTPS | `https://mydns.lkbin.my.id/unfiltered` | [Add to AdGuard](adguard:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id) | | ||
|
|
||
| #### ANTIVIRUS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section title 'ANTIVIRUS' doesn't match the description which refers to 'DNS Anti Malware / DNS Antivirus'. For consistency, consider renaming this section to 'ANTI MALWARE' or 'ANTI-MALWARE' to better reflect the service description.
|
I've made the necessary repairs. /windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
docs/general/dns-providers.md
Outdated
| |----------------|----------------------------------------------------|----------------| | ||
| | DNS-over-HTTPS | `https://mydns.lkbin.my.id/unfiltered` | [Add to AdGuard](adguard:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id) | | ||
|
|
||
| #### ANTIVIRUS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section title 'ANTIVIRUS' doesn't match the description which refers to 'DNS Anti Malware' and the URL path '/antivirus'. Consider renaming this section to 'ANTI MALWARE' or 'ANTI-MALWARE' for consistency.
docs/general/dns-providers.md
Outdated
| #### ADGUARD FILTER | ||
|
|
||
| This DNS service uses AdGuard’s advanced filtering technology to block ads, trackers, and malicious domains directly at the DNS level. By leveraging AdGuard’s regularly updated blocklists, it enhances privacy, improves browsing speed, and protects users from harmful or unwanted online content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'ADGUARD FILTER' section mentions using AdGuard's filtering technology, but doesn't clarify the relationship between LKBIN DNS and AdGuard. It would be helpful to specify whether this is an official partnership or if LKBIN is independently implementing AdGuard's technology.
asop-linu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check again /windsurf-review
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
docs/general/dns-providers.md
Outdated
| |----------------|----------------------------------------------------|----------------| | ||
| | DNS-over-HTTPS | `https://mydns.lkbin.my.id/unfiltered` | [Add to AdGuard](adguard:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id) | | ||
|
|
||
| #### ANTIVIRUS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a naming inconsistency between the section title 'ANTIVIRUS' and the description which refers to 'Anti Malware'. Consider using consistent terminology throughout.
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
docs/general/dns-providers.md
Outdated
| Antivirus is a protective DNS service designed to safeguard users against online threats. | ||
| It automatically blocks access to domains associated with malware, ransomware, and phishing attacks, helping ensure a safer and more secure browsing experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an unnecessary double space in the Antivirus description between 'online threats.' and 'It automatically'.
| Antivirus is a protective DNS service designed to safeguard users against online threats. | |
| It automatically blocks access to domains associated with malware, ransomware, and phishing attacks, helping ensure a safer and more secure browsing experience. | |
| Antivirus is a protective DNS service designed to safeguard users against online threats. It automatically blocks access to domains associated with malware, ransomware, and phishing attacks, helping ensure a safer and more secure browsing experience. |
docs/general/dns-providers.md
Outdated
| |----------------|----------------------------------------------------|----------------| | ||
| | DNS-over-HTTPS | `https://mydns.lkbin.my.id/unfiltered` | [Add to AdGuard](adguard:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id) | | ||
|
|
||
| #### ANTIVIRUS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an inconsistency between the section title 'ANTIVIRUS' and the description which refers to the service as 'Anti Malware' in the PR description. Consider using consistent terminology throughout the document.
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
|
|
||
| ### LKBIN DNS | ||
|
|
||
| [LKBIN DNS](https://mydns.lkbin.my.id/) is a free recursive DNS service that is committed to delivering fast, stable, and secure DNS resolution for Internet users. It integrates DNSSEC for authenticity, blocks ads and malware to enhance safety, and supports only DoH (DNS over HTTPS) to protect user privacy. For your information, we do not store logs or user data on this service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the PR mentions "we do not store logs or user data on this service", it would be helpful to include a link to LKBIN DNS's privacy policy or more detailed information about their data handling practices, as this is typically included for DNS providers in this knowledge base.
|
|
||
| ### LKBIN DNS | ||
|
|
||
| [LKBIN DNS](https://mydns.lkbin.my.id/) is a free recursive DNS service that is committed to delivering fast, stable, and secure DNS resolution for Internet users. It integrates DNSSEC for authenticity, blocks ads and malware to enhance safety, and supports only DoH (DNS over HTTPS) to protect user privacy. For your information, we do not store logs or user data on this service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding information about the server locations or infrastructure of LKBIN DNS to help users understand potential latency or jurisdictional implications of using this service.
| |----------------|----------------------------------------------------|----------------| | ||
| | DNS-over-HTTPS | `https://mydns.lkbin.my.id/unfiltered` | [Add to AdGuard](adguard:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://mydns.lkbin.my.id/unfiltered&name=mydns.lkbin.my.id) | | ||
|
|
||
| #### ANTI MALWARE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's inconsistent capitalization in the Anti Malware section. Consider standardizing the capitalization style across all service names for consistency.
| #### ANTI MALWARE | |
| #### Anti Malware |
Added information about LKBIN DNS and its various services, including AdBlock, Unfiltered, Anti Malware, Family DNS, Hagezi Filter, and AdGuard Filter.