AGM-2763-Added CERT EE to the list of known providers #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
|
|
||
| | Protocol | Address | | | ||
| |----------------|----------------------------------------------------|----------------| | ||
| | DNS-over-HTTPS | `https://dns.cert.ee/dns-query` | [Add to AdGuard](adguard:add_dns_server?address=https://dns.cert.ee/dns-query/query&name=dns.cert.ee/dns-query), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://dns.cert.ee/dns-query/query&name=dns.cert.ee/dns-query) | |
Contributor
There was a problem hiding this comment.
There's a duplication in the DoH URL for the 'Add to AdGuard' links. The URL should be dns.cert.ee/dns-query but the link has /query appended twice, making it dns.cert.ee/dns-query/query.
Suggested change
| | DNS-over-HTTPS | `https://dns.cert.ee/dns-query` | [Add to AdGuard](adguard:add_dns_server?address=https://dns.cert.ee/dns-query/query&name=dns.cert.ee/dns-query), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://dns.cert.ee/dns-query/query&name=dns.cert.ee/dns-query) | | |
| | DNS-over-HTTPS | `https://dns.cert.ee/dns-query` | [Add to AdGuard](adguard:add_dns_server?address=https://dns.cert.ee/dns-query&name=dns.cert.ee/dns-query), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://dns.cert.ee/dns-query&name=dns.cert.ee/dns-query) | |
| | Protocol | Address | | | ||
| |----------------|----------------------------------------------------|----------------| | ||
| | DNS-over-HTTPS | `https://dns.cert.ee/dns-query` | [Add to AdGuard](adguard:add_dns_server?address=https://dns.cert.ee/dns-query/query&name=dns.cert.ee/dns-query), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=https://dns.cert.ee/dns-query/query&name=dns.cert.ee/dns-query) | | ||
| | DNS-over-TLS | `tls://dns.cert.ee` | [Add to AdGuard](adguard:add_dns_server?address=tls://tls://dns.cert.ee&name=dns.cert.ee), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=tls://dns.cert.ee&name=dns.cert.ee) | |
Contributor
There was a problem hiding this comment.
There's a duplication of the tls:// prefix in the 'Add to AdGuard' link for DNS-over-TLS. It currently has tls://tls://dns.cert.ee which is incorrect.
Suggested change
| | DNS-over-TLS | `tls://dns.cert.ee` | [Add to AdGuard](adguard:add_dns_server?address=tls://tls://dns.cert.ee&name=dns.cert.ee), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=tls://dns.cert.ee&name=dns.cert.ee) | | |
| | DNS-over-TLS | `tls://dns.cert.ee` | [Add to AdGuard](adguard:add_dns_server?address=tls://dns.cert.ee&name=dns.cert.ee), [Add to AdGuard VPN](adguardvpn:add_dns_server?address=tls://dns.cert.ee&name=dns.cert.ee) | |
|
Preview was deployed to: https://pull-request-376.kb-dns.pages.dev/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.