Consistent type imports and exports in AGTree

Merge in ADGUARD-FILTERS/tsurlfilter from fix/agtree-type-imports to master

Squashed commit of the following:

commit 146385b
Merge: 62a3415 fd3ec59
Author: scripthunter7 <[email protected]>
Date:   Thu Aug 10 09:31:51 2023 +0200

    Merge branch 'master' into fix/agtree-type-imports

commit 62a3415
Author: scripthunter7 <[email protected]>
Date:   Wed Aug 9 12:25:29 2023 +0200

    Fix linter errors

commit 755feac
Author: scripthunter7 <[email protected]>
Date:   Wed Aug 9 12:24:53 2023 +0200

    Update ESLint config

Author: scripthunter7

packages/agtree/.eslintrc.cjs

@@ -67,5 +67,18 @@ module.exports = {
         ],
         'arrow-body-style': 'off',
         'no-await-in-loop': 'off',
+        // Force proper import and export of types
+        '@typescript-eslint/consistent-type-imports': [
+            'error',
+            {
+                fixStyle: 'inline-type-imports',
+            },
+        ],
+        '@typescript-eslint/consistent-type-exports': [
+            'error',
+            {
+                fixMixedExportsWithInlineTypeSpecifier: true,
+            },
+        ],
     },
 };

packages/agtree/src/ast-utils/modifiers.ts

@@ -4,7 +4,7 @@
 
 import cloneDeep from 'clone-deep';
 
-import { Modifier, ModifierList } from '../parser/common';
+import { type Modifier, type ModifierList } from '../parser/common';
 import { isUndefined } from '../utils/common';
 
 /**

packages/agtree/src/ast-utils/scriptlets.ts

@@ -4,8 +4,8 @@
 
 import cloneDeep from 'clone-deep';
 
-import { ParameterList } from '../parser/common';
-import { QuoteType, setStringQuoteType } from '../utils/quotes';
+import { type ParameterList } from '../parser/common';
+import { type QuoteType, setStringQuoteType } from '../utils/quotes';
 
 /**
  * Get name of the scriptlet from the scriptlet node

packages/agtree/src/converter/base-interfaces/rule-converter-base.ts

@@ -9,7 +9,7 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
 import { NotImplementedError } from '../../errors/not-implemented-error';
-import { Node } from '../../parser/common';
+import { type Node } from '../../parser/common';
 import { ConverterBase } from './converter-base';
 
 /**

packages/agtree/src/converter/comment/index.ts

@@ -4,7 +4,7 @@
 
 import cloneDeep from 'clone-deep';
 
-import { AnyCommentRule, CommentMarker, CommentRuleType } from '../../parser/common';
+import { type AnyCommentRule, CommentMarker, CommentRuleType } from '../../parser/common';
 import { SPACE } from '../../utils/constants';
 import { RuleConverterBase } from '../base-interfaces/rule-converter-base';
 

packages/agtree/src/converter/cosmetic/css.ts

@@ -3,9 +3,9 @@
  */
 
 import cloneDeep from 'clone-deep';
-import { SelectorList, fromPlainObject } from '@adguard/ecss-tree';
+import { type SelectorList, fromPlainObject } from '@adguard/ecss-tree';
 
-import { CosmeticRuleSeparator, CssInjectionRule } from '../../parser/common';
+import { CosmeticRuleSeparator, type CssInjectionRule } from '../../parser/common';
 import { RuleConverterBase } from '../base-interfaces/rule-converter-base';
 import { CssSelectorConverter } from '../css';
 import { AdblockSyntax } from '../../utils/adblockers';

packages/agtree/src/converter/cosmetic/element-hiding.ts

@@ -3,9 +3,9 @@
  */
 
 import cloneDeep from 'clone-deep';
-import { SelectorList, fromPlainObject } from '@adguard/ecss-tree';
+import { type SelectorList, fromPlainObject } from '@adguard/ecss-tree';
 
-import { CosmeticRuleSeparator, ElementHidingRule } from '../../parser/common';
+import { CosmeticRuleSeparator, type ElementHidingRule } from '../../parser/common';
 import { CssTree } from '../../utils/csstree';
 import { RuleConverterBase } from '../base-interfaces/rule-converter-base';
 import { CssSelectorConverter } from '../css';

packages/agtree/src/converter/cosmetic/html.ts

@@ -2,13 +2,13 @@
  * @file HTML filtering rule converter
  */
 
-import { SelectorPlain } from '@adguard/ecss-tree';
+import { type SelectorPlain } from '@adguard/ecss-tree';
 import cloneDeep from 'clone-deep';
 
 import {
     CosmeticRuleSeparator,
     CosmeticRuleType,
-    HtmlFilteringRule,
+    type HtmlFilteringRule,
     RuleCategory,
 } from '../../parser/common';
 import { AdblockSyntax } from '../../utils/adblockers';

packages/agtree/src/converter/cosmetic/rule-modifiers/adg.ts

@@ -2,9 +2,9 @@
  * @file Cosmetic rule modifier converter from uBO to ADG
  */
 
-import { ModifierList } from '../../../parser/common';
+import { type ModifierList } from '../../../parser/common';
 import { RuleConversionError } from '../../../errors/rule-conversion-error';
-import { ConverterFunction } from '../../base-interfaces/converter-function';
+import { type ConverterFunction } from '../../base-interfaces/converter-function';
 import { createModifierListNode, createModifierNode } from '../../../ast-utils/modifiers';
 import { RegExpUtils } from '../../../utils/regexp';
 import {

packages/agtree/src/converter/cosmetic/scriptlet.ts

@@ -4,7 +4,7 @@
 
 import cloneDeep from 'clone-deep';
 
-import { CosmeticRuleSeparator, ParameterList, ScriptletInjectionRule } from '../../parser/common';
+import { CosmeticRuleSeparator, type ParameterList, type ScriptletInjectionRule } from '../../parser/common';
 import { RuleConverterBase } from '../base-interfaces/rule-converter-base';
 import { AdgScriptletConverter } from './scriptlets/adg';
 import { AdblockSyntax } from '../../utils/adblockers';