Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPT-92] Mentors: Track Clicks on Elasticsearch #772

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[MPT-92] Mentors: Track Clicks on Elasticsearch #772

wants to merge 7 commits into from
+391 −15

Conversation

Unknownflow
Copy link
Contributor

draft pr for terence

@netlify Netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for tender-meitner-99286b ready!

Name Link
🔨 Latest commit f319790
🔍 Latest deploy log https://app.netlify.com/sites/tender-meitner-99286b/deploys/66b45ed5483a07000812c6e5
😎 Deploy Preview https://deploy-preview-772--tender-meitner-99286b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 85
Accessibility: 97
Best Practices: 100
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Unknownflow Unknownflow marked this pull request as draft June 17, 2024 05:49
@Unknownflow Unknownflow linked an issue Jun 27, 2024 that may be closed by this pull request
[MPT-92] Mentors: Track Clicks on Elasticsearch #743
Open
@Unknownflow Unknownflow changed the title [MPT-92] Mentors: Track Clicks on Elasticsearch (draft pr) [MPT-92] Mentors: Track Clicks on Elasticsearch Jul 8, 2024
@Unknownflow Unknownflow marked this pull request as ready for review July 8, 2024 13:16
@Unknownflow Unknownflow self-assigned this Jul 15, 2024
@wei2912 wei2912 requested review from Hackin7 and wei2912 and removed request for Hackin7 July 21, 2024 13:44
@wei2912 wei2912 marked this pull request as draft July 21, 2024 13:46
wei2912
wei2912 requested changes Jul 21, 2024
View reviewed changes
Copy link
Member

@wei2912 wei2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be revisited after launch (due to concerns with overloading server), will do a second review after the above change is addressed along with some testing.

scripts/trackClicks.js Outdated

// search query retrieves the mentor's info
const searchQuery = JSON.stringify({
query: mentor_name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the search term used instead of just the mentor name.

@wei2912 wei2912 marked this pull request as ready for review September 21, 2024 14:12
@wei2912
Copy link
Member

wei2912 commented Sep 21, 2024

Marking as ready for review - to be checked.

@wei2912
Copy link
Member

wei2912 commented Nov 30, 2024

@Hackin7 reassigned to you, we gotta discuss this further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wei2912 wei2912 wei2912 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Unknownflow Unknownflow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MPT-92] Mentors: Track Clicks on Elasticsearch
2 participants
@Unknownflow @wei2912